Bug 18689 - Function `XGetXCBConnection' implicitly converted to pointer at single2.c:890 causes crash on 64bit maschines
Summary: Function `XGetXCBConnection' implicitly converted to pointer at single2.c:890...
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: GLX (show other bugs)
Version: unspecified
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: mesa-dev
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-24 11:32 UTC by Bernd Buschinski
Modified: 2008-11-24 11:41 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
fix missing include (255 bytes, patch)
2008-11-24 11:32 UTC, Bernd Buschinski 		Details | Splinter Review
View All

Description Bernd Buschinski 2008-11-24 11:32:43 UTC 
Created attachment 20560 [details] [review]
fix missing include

While compiling mesa master (153cc70ddb52a2acc5a4790adc6d7a7b2ddf0d43)
on gentoo I got the following QA Notice

* QA Notice: Package has poor programming practices which may compile 
*            but will almost certainly crash on 64bit architectures. 
* 
* Function `XGetXCBConnection' implicitly converted to pointer at single2.c:890

and it did crash on my 64bit maschine.

patch fixes the missing include and makes it work
Comment 1 Eric Anholt 2008-11-24 11:41:48 UTC 
commit d52e8543b61ec5b8b8d9b1574a28ae2472fe4c56
Author: Bernd Buschinski <b.buschinski@web.de>
Date:   Mon Nov 24 11:39:07 2008 -0800

    glx: Add missing include for XCB, fixing crash on 64-bit.
    
    Bug #18689

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.