Bug 18752 - [codegen] Only use properties mixin if properties are used
Summary: [codegen] Only use properties mixin if properties are used
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-glib (show other bugs)
Version: unspecified
Hardware: All Linux (All)
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-28 02:33 UTC by Ross Burton
Modified: 2009-01-12 04:50 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
Only use the mixin if there are properties (4.23 KB, patch)
2008-11-28 02:33 UTC, Ross Burton 		Details | Splinter Review
Only include the mixin headers if required (1.73 KB, patch)
2008-11-28 02:33 UTC, Ross Burton 		Details | Splinter Review
View All

Description Ross Burton 2008-11-28 02:33:17 UTC 
Created attachment 20654 [details] [review]
Only use the mixin if there are properties

At the moment the telepathy-glib ginterface code generator will always include telepathy-glib/dbus-properties-mixin.h and use it even if there are no properties in that interface.  Attaching a patch set which makes the codegen detect this and not use the mixin if it can avoid it.

The purpose of this is so that generated ginterfaces without properties are standalone and don't require telepathy-glib at all.
Comment 1 Ross Burton 2008-11-28 02:33:42 UTC 
Created attachment 20655 [details] [review]
Only include the mixin headers if required
Comment 2 Simon McVittie 2009-01-12 04:50:12 UTC 
Fixed in 0.7.19

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.