Bug 18925 - GNOME Goal: Clean up GLib and GTK+ includes
Summary: GNOME Goal: Clean up GLib and GTK+ includes
Status: RESOLVED DUPLICATE of bug 18240
Alias: None
Product: poppler
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: poppler-bugs
QA Contact:
URL: http://bugzilla.gnome.org/show_bug.cg...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-07 08:43 UTC by Luis Menina
Modified: 2008-12-13 08:26 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
simple patch (15.95 KB, patch)
2008-12-07 08:44 UTC, Luis Menina 		Details | Splinter Review
View All

Description Luis Menina 2008-12-07 08:43:24 UTC 
Correct applications or libraries that don't include
*only* toplevel headers for GLib, GTK, GDK and gdk-pixbuf. This will be useful
to prepare GTK 3.0 migration.

See also http://live.gnome.org/GnomeGoals/CleanupGTKIncludes
Comment 1 Luis Menina 2008-12-07 08:44:39 UTC 
Created attachment 20870 [details] [review]
simple patch
Comment 2 Carlos Garcia Campos 2008-12-12 04:56:38 UTC 
This was already reported and fixed. Thanks. 

*** This bug has been marked as a duplicate of bug 18240 ***
Comment 3 Luis Menina 2008-12-12 13:38:26 UTC 
You're wrong, look at the patches. The patch in bug 18240 fixes compilation only for GDK_DISABLE_SINGLE_INCLUDES, while mine fixes  GDK_PIXBUF_DISABLE_SINGLE_INCLUDES *and* GTK_DISABLE_SINGLE_INCLUDES (and G_DISABLE_SINGLE_INCLUDES, but there are no deprecated GLib symbols used in poppler anyway).
Comment 4 Carlos Garcia Campos 2008-12-13 08:26:26 UTC 
Yes, the attached patch didn't fix everything but I did so. See commits:

http://cgit.freedesktop.org/poppler/poppler/commit/?id=a84d272ffd2b593ac98148e71b83fba299c60fea
http://cgit.freedesktop.org/poppler/poppler/commit/?id=a5865dae5b414de5f6dbda2a512101050c374e06



*** This bug has been marked as a duplicate of bug 18240 ***

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.