Bug 19098 - [cosmetic] various fixes
Summary: [cosmetic] various fixes
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/Radeon (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: xf86-video-ati maintainers
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-15 07:47 UTC by Fabio Pedretti
Modified: 2008-12-15 08:35 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
radeon.man.patch (2.78 KB, patch)
2008-12-15 07:47 UTC, Fabio Pedretti
no flags Details | Splinter Review
ati_pciids.csv.patch (2.03 KB, patch)
2008-12-15 07:48 UTC, Fabio Pedretti
no flags Details | Splinter Review

Description Fabio Pedretti 2008-12-15 07:47:32 UTC
Created attachment 21175 [details] [review]
radeon.man.patch

1) radeon.man.patch
- clarify supported features (hoping that users stop asking things like "why I can't use Xv on my RV670?" in irc/forum/ml);
- improve readability avoiding adding an empty line between every card in the SUPPORTED HARDWARE;

2) ati_pciids.csv.patch
- remove some duplicated "ATI ATI " in cards name

Also some things to ask:

a) ati_pciids.csv says that the "ATI Radeon HD 4870 x2" is a RV770. Shouldn't says R700?

b) MergedFB support was removed some time ago. However a grep -ri mergedfb revealed there are some traces of it (mostly in comments), e.g.:

src/radeon_driver.c:

   if (xf86IsEntityShared(info->pEnt->index)) {
        xf86DrvMsg(pScrn->scrnIndex, X_WARNING,
                   "Direct Rendering Disabled -- "
                   "Dual-head configuration is not working with "
                   "DRI at present.\n"
                   "Please use the radeon MergedFB option if you "
                   "want Dual-head with DRI.\n");
        return FALSE;
    }

src/legacy_crtc.c:

/* note cannot use pScrn->pScreen since this is unitialized when called from
RADEONScreenInit, and we need to call from there to get mergedfb + pageflip working */
Comment 1 Fabio Pedretti 2008-12-15 07:48:12 UTC
Created attachment 21176 [details] [review]
ati_pciids.csv.patch
Comment 2 Alex Deucher 2008-12-15 08:35:17 UTC
pushed:
c7899905ec824071f9cabbd1e271c4d76010b733
94bffac6968057cdedc792f8540fe44cb6ecfd7c
f1efee6a11dc9436276fb12cfb90aa79ada1192b

thanks!

To answer your question, 4870's are rv770 chips.  There is plain r700.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.