Bug 19196 - Enable -Werror by default with --enable-maintainer-mode, and change warnings
Summary: Enable -Werror by default with --enable-maintainer-mode, and change warnings
Status: RESOLVED FIXED
Alias: None
Product: dbus
Classification: Unclassified
Component: core (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Havoc Pennington
QA Contact: John (J5) Palmieri
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-19 17:07 UTC by Colin Walters
Modified: 2009-01-06 13:06 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
Enable -Werror by default with --enable-maintainer-mode, and change warnings (2.53 KB, patch)
2008-12-19 17:07 UTC, Colin Walters 		Details | Splinter Review
Various compiler warning fixes (3.69 KB, patch)
2008-12-19 17:10 UTC, Colin Walters 		Details | Splinter Review
View All

Description Colin Walters 2008-12-19 17:07:55 UTC 
Created attachment 21335 [details] [review]
Enable -Werror by default with --enable-maintainer-mode, and change warnings

Important compiler warnings were being lost in the noise from warnings
    we know about but aren't problems, and moreover made using -Werror
    difficult.  Now we expect *all* developers and testers to be using
    -Werror.
Comment 1 Colin Walters 2008-12-19 17:10:09 UTC 
Created attachment 21336 [details] [review]
 Various compiler warning fixes
Comment 2 Havoc Pennington 2008-12-26 06:50:46 UTC 
Patches look good to me.
Comment 3 Colin Walters 2009-01-06 13:06:02 UTC 
Committed, thanks for the review.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.