Bug 19724 - xf86-input-keyboard-1.3.2-5-g14267d8 build failure
Summary: xf86-input-keyboard-1.3.2-5-g14267d8 build failure
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Input/Keyboard (show other bugs)
Version: git
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
: 19828 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-01-24 09:40 UTC by Ingmar Vanhassel
Modified: 2009-03-16 19:49 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments
build log (16.33 KB, text/plain)
2009-01-24 09:40 UTC, Ingmar Vanhassel
no flags Details
Changes to make xf86-input-keyboard work (9.72 KB, patch)
2009-01-28 16:02 UTC, Pierre Willenbrock
no flags Details | Splinter Review

Description Ingmar Vanhassel 2009-01-24 09:40:30 UTC
Created attachment 22207 [details]
build log

xf86-input-keyboard-1.3.2-5-g14267d8 (latest git) fails to build atm.

I'm building against current git of
- xorg-server (759348f13ffa02fb1804238189ffce1c92d33e2a)
- inputproto (7203036522ba9d4b224d282d6afc2d0b947711ee)
- libXi (d0326fe8cdbb08d4f52d79fd3fd4e1b2a0951d5e)


libtool: compile:  x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I.. -Wall -Wpointer-arith -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wnested-externs -fno-strict-aliasing -Wbad-function-cast -Wold-style-definition -Wdeclaration-after-statement -fvisibility=hidden -I/usr/include/xorg -I/usr/include/pixman-1 -march=core2 -pipe -O2 -ggdb -D__INGMAR_CFLAGS__ -MT lnx_KbdMap.lo -MD -MP -MF .deps/lnx_KbdMap.Tpo -c lnx_KbdMap.c  -fPIC -DPIC -o .libs/lnx_KbdMap.o                                                                                                                                              
libtool: compile:  x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I.. -Wall -Wpointer-arith -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wnested-externs -fno-strict-aliasing -Wbad-function-cast -Wold-style-definition -Wdeclaration-after-statement -fvisibility=hidden -I/usr/include/xorg -I/usr/include/pixman-1 -march=core2 -pipe -O2 -ggdb -D__INGMAR_CFLAGS__ -MT at_scancode.lo -MD -MP -MF .deps/at_scancode.Tpo -c at_scancode.c  -fPIC -DPIC -o .libs/at_scancode.o                                                                                                                                          
libtool: compile:  x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I.. -Wall -Wpointer-arith -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wnested-externs -fno-strict-aliasing -Wbad-function-cast -Wold-style-definition -Wdeclaration-after-statement -fvisibility=hidden -I/usr/include/xorg -I/usr/include/pixman-1 -march=core2 -pipe -O2 -ggdb -D__INGMAR_CFLAGS__ -MT lnx_kbd.lo -MD -MP -MF .deps/lnx_kbd.Tpo -c lnx_kbd.c  -fPIC -DPIC -o .libs/lnx_kbd.o                                                                                                                                                          
mv -f .deps/at_scancode.Tpo .deps/at_scancode.Plo                                                                                                                                                              
mv -f .deps/lnx_KbdMap.Tpo .deps/lnx_KbdMap.Plo                                                                                                                                                                
lnx_kbd.c: In function 'SetKbdRepeat':                                                                                                                                                                         
lnx_kbd.c:184: warning: unused variable 'valid_delays'                                                                                                                                                         
lnx_kbd.c:178: warning: unused variable 'valid_rates'                                                                                                                                                          
lnx_kbd.c:168: warning: unused variable 'value'                                                                                                                                                                
lnx_kbd.c:167: warning: unused variable 'timeout'                                                                                                                                                              
lnx_kbd.c:166: warning: unused variable 'i'                                                                                                                                                                    
mv -f .deps/lnx_kbd.Tpo .deps/lnx_kbd.Plo                                                                                                                                                                      
kbd.c: In function 'KbdProc':                                                                                                                                                                                  
kbd.c:567: warning: passing argument 1 of 'InitKeyboardDeviceStruct' from incompatible pointer type                                                                                                            
kbd.c:567: warning: passing argument 2 of 'InitKeyboardDeviceStruct' from incompatible pointer type                                                                                                            
kbd.c:567: warning: passing argument 3 of 'InitKeyboardDeviceStruct' from incompatible pointer type                                                                                                            
kbd.c:567: warning: passing argument 4 of 'InitKeyboardDeviceStruct' from incompatible pointer type                                                                                                            
kbd.c:567: error: too many arguments to function 'InitKeyboardDeviceStruct'                                                                                                                                    
kbd.c: In function 'PostKbdEvent':                                                                                                                                                                             
kbd.c:699: error: 'KeyClassRec' has no member named 'state'                                                                                                                                                    
kbd.c:702: error: 'KeyClassRec' has no member named 'state'                                                                                                                                                    
kbd.c:714: error: 'KeyClassRec' has no member named 'state'                                                                                                                                                    
kbd.c:726: error: 'KeyClassRec' has no member named 'curKeySyms'                                                                                                                                               
kbd.c:727: error: 'KeyClassRec' has no member named 'curKeySyms'                                                                                                                                               
kbd.c:728: error: 'KeyClassRec' has no member named 'curKeySyms'                                                                                                                                               
kbd.c:791: error: 'KeyClassRec' has no member named 'modifierMap'                                                                                                                                              
kbd.c:847: error: 'KeyClassRec' has no member named 'modifierMap'                                                                                                                                              
kbd.c:854: error: 'KeyClassRec' has no member named 'modifierKeyMap'                                                                                                                                           
kbd.c:854: error: 'KeyClassRec' has no member named 'maxKeysPerModifier'                                                                                                                                       
kbd.c:857: error: 'KeyClassRec' has no member named 'modifierKeyMap'                                                                                                                                           
kbd.c:857: error: 'KeyClassRec' has no member named 'maxKeysPerModifier'                                                                                                                                       
kbd.c: At top level:                                                                                                                                                                                           
kbd.c:863: warning: 'ModuleInfoRec' is deprecated                                                                                                                                                              
make[2]: *** [kbd.lo] Error 1                                                                                                                                                                                  


Full log attached...
Comment 1 Pierre Willenbrock 2009-01-28 16:02:10 UTC
Created attachment 22332 [details] [review]
Changes to make xf86-input-keyboard work

Attaching changes needed to make xf86-input-keyboard compile and work. This completely ignores backwards compatibility, and the XkbDflt*-symbols probably need different handling. 

I can attach the seven patches that fix the problems created by single xserver-commits, if needed(instead of this single patch that contains all the changes).
Comment 2 Julien Cristau 2009-01-30 07:12:19 UTC
*** Bug 19828 has been marked as a duplicate of this bug. ***
Comment 3 Alan Coopersmith 2009-03-16 19:49:12 UTC
Daniel & Peter fixed this in git in February.   Closing.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.