Created attachment 22372 [details] [review] patch evdev.c Problem located in evdev.c / EvdevCacheCompare() Symptom: USB touchscreen no longer works when switching from X to another virtual console and then back to X. Sample log message: (EE) Elo TouchSystems, Inc. Elo TouchSystems 2700 IntelliTouch(r) USB Touchmonitor Interface: Device has changed - disabling. (WW) Elo TouchSystems, Inc. Elo TouchSystems 2700 IntelliTouch(r) USB Touchmonitor Interface: Release failed (Invalid argument) Cause: EvdevCacheCompare fails because it also compares all values of input_absinfo structure, which include the last tapped position of the touchscreen (.value field). This is never updated in the cache, and anyway it could change anytime if the screen is touched while away from the X virtual console. Solution: Exclude .value from comparison. One-liner patch attached.
ACK, please add a comment describing why this line is needed (in the source code) and resubmit as git-formatted patch.
Created attachment 22380 [details] [review] patch evdev.c (git diff) New patch attached as requested.
Sorry, I wasn't clear enough. I'd like to see a patch produced with git format-patch. This way the authorship and commit message is already there. In the commit message, please include a reference to this bug and as much information as you deem necessary to understand the reason for the change (e.g. the content of your original comment). ACK to the patch itself.
Created attachment 22466 [details] [review] patch evdev.c (git format-patch)
> --- Comment #4 from Julien Plissonneau Duquene <julien.plissonneau.duquene@savoirfairelinux.com> 2009-02-02 05:56:07 PST --- > Created an attachment (id=22466) > --> (http://bugs.freedesktop.org/attachment.cgi?id=22466) > patch evdev.c (git format-patch) > getting there :) The first line in the commit message should be a short description of the change (something like "EvdevCacheCompare: ignore current position", I guess) which is more meaningful than a simple bug number. The reference to this bug can go at the end of the message. Thanks!
Created attachment 22478 [details] [review] patch evdev.c (git format-patch again) It would probably help to be a wee bit more specific about the expected patch format in http://www.x.org/wiki/DeveloperStart ...
> --- Comment #6 from Julien Plissonneau Duquene <julien.plissonneau.duquene@savoirfairelinux.com> 2009-02-02 08:01:50 PST --- > Created an attachment (id=22478) > --> (http://bugs.freedesktop.org/attachment.cgi?id=22478) > patch evdev.c (git format-patch again) > Signed-off-by: Julien Cristau <jcristau@debian.org> I'll let Peter push this if he's happy with it too :) > It would probably help to be a wee bit more specific about the expected patch > format in http://www.x.org/wiki/DeveloperStart ... > agreed. thanks for your perseverance :)
Pushed as 0dbb88c52b057cfdff6116060060841e4fc4abb5. Thanks for the patch (and the patience).
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.