Bug 19907 - Add tp_intset_new_singleton(guint i)
Summary: Add tp_intset_new_singleton(guint i)
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-glib (show other bugs)
Version: unspecified
Hardware: Other All
: low enhancement
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-02 06:52 UTC by Simon McVittie
Modified: 2009-02-16 09:55 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Simon McVittie 2009-02-02 06:52:39 UTC
telepathy-gabble and other CMs frequently construct TpIntSet instances with one member. It would be convenient to have a function for this.
Comment 2 Jonathon Jongsma 2009-02-03 13:00:51 UTC
Personally, I find the terminology _new_singleton() more confusing than helpful since a singleton generally has a very specific design-pattern meaning and it's being used for something quite different here.  I think _new_single() might be slightly better, but there could be better options.
Comment 3 Will Thompson 2009-02-03 13:26:59 UTC
That's a fair point.

_new_from_element? _new_from_elt?
Comment 4 Simon McVittie 2009-02-04 04:30:49 UTC
Perhaps tp_intset_new_containing? "tp_intset_new_containing (123)" sounds fairly unambiguous to me :-)
Comment 5 Will Thompson 2009-02-04 05:15:28 UTC
I agree, and have made that change.
Comment 6 Simon McVittie 2009-02-16 09:55:06 UTC
Fixed in 0.7.26


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.