Bug 19992 - cairo-features.h included in tarball
Summary: cairo-features.h included in tarball
Status: RESOLVED FIXED
Alias: None
Product: cairo
Classification: Unclassified
Component: general (show other bugs)
Version: 1.8.6
Hardware: Other All
: medium normal
Assignee: Carl Worth
QA Contact: cairo-bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-06 08:04 UTC by Marko Lindqvist
Modified: 2009-02-06 09:57 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments

Description Marko Lindqvist 2009-02-06 08:04:32 UTC 
Cairo versions 1.8.x tarballs contain src/cairo-features.h. This gets #included instead of correct, generated, one when builddir != srcdir. Problem does not exist if srcdir == builddir, since tarball version gets overwritten by generated one.
Comment 1 Behdad Esfahbod 2009-02-06 08:58:56 UTC 
Hummmmm.  I fixed this quite a while ago:

commit a7595c1295ba1a58b452b1df31d02776e5c17c0f
Author: Behdad Esfahbod <behdad@behdad.org>
Date:   Tue Mar 13 17:21:19 2007 -0400

    [Makefile.am] Do not distribute cairo-features.h, Ouch!
    
    We were accidentally doing that by not marking it noinst.
    Moreover, no need to mark it as BUILD_SOURCES, since it's
    created by configure, not make.


No idea why it's happening again.
Comment 2 Behdad Esfahbod 2009-02-06 09:57:37 UTC 
Fixed in master:

commit c22ca79863a54b4293e607c8e4d515868c216842
Author: Behdad Esfahbod <behdad@behdad.org>
Date:   Fri Feb 6 12:56:48 2009 -0500

    Don't distribute cairo-features.h (#19992)
    
    Second time I fix this bug.  Mabe we should add a test for it!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.