Bug 20080 - KeyFile: ";" as a list may be mis-parsed
Summary: KeyFile: ";" as a list may be mis-parsed
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-qt (show other bugs)
Version: unspecified
Hardware: Other All
: low minor
Assignee: Andre Moreira Magalhaes
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-12 05:58 UTC by Simon McVittie
Modified: 2009-06-30 13:52 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Simon McVittie 2009-02-12 05:58:58 UTC 
The test data says

default-empty-list = ;

but that shouldn't be interpreted as an empty list, AIUI; it should be a list containing one empty string.
Comment 1 Simon McVittie 2009-06-22 09:24:08 UTC 
http://git.collabora.co.uk/?p=user/andrunko/telepathy-qt4.git;a=shortlog;h=refs/heads/key-file looks like a good change. However, tests/telepathy/managers/test-manager-file.manager still contains:

  56 # the value is an empty list
  57 param-empty-list = as
  58 default-empty-list = ;

which is clearly wrong - either it's wrongly being parsed as an empty list (even though it should be a list of one empty string), or the name and comment are wrong.

Further, tests/manager-file.cpp does not actually test that key (except asserting that it exists).

So, please fix this: this bug should not be closed yet. Assigning to Andre.
Comment 2 Andre Moreira Magalhaes 2009-06-30 13:52:40 UTC 
Fixed upstream, it will be in next release 0.1.9

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.