Bug 20157 - PendingConnection should produce a QSharedPointer<Connection> with no parent
Summary: PendingConnection should produce a QSharedPointer<Connection> with no parent
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-qt (show other bugs)
Version: unspecified
Hardware: Other All
: high enhancement
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-17 04:13 UTC by Simon McVittie
Modified: 2009-04-23 06:57 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Simon McVittie 2009-02-17 04:13:51 UTC
12:10 < smcv> andrunko, oggis_: in PendingConnection, should the 
              ConnectionManager really be the parent of the resulting 
              Connection, btw?
12:10 < oggis_> no it shouldn't
12:10 < oggis_> definitely not
12:10 < oggis_> it should return a shared pointer to a connection with no 
                parent at all
12:10 < oggis_> parents and shared pointers generally don't mix
12:10 < oggis_> when a parent deletes its children, the shared pointers will 
                become dangling
Comment 1 Simon McVittie 2009-02-17 04:59:12 UTC
Fixed in git already, sorry for the spam


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.