When setting the avatar fails, Gabble does not correctly re-map the error from its internal XMPP GError domain to TP_ERRORS. As a result, "org.freedesktop.DBus.GLib.UnmappedError.GabbleXmppError.Code3" is raised. This can probably be reproduced by setting an excessively large avatar on a Google Talk account.
wjt/no-avatar-for-you seems to (attempt to?) fix this. Is this a candidate for review? Does it claim to fix this bug? (if so please reference it as fd.o#20422 in the commit messages)
ISTR I wanted to do some more refactoring. I'll pick it back up when I have a minute.
I've updated the branch. I think it's ready for review. src/conn-avatars.c | 34 +++++++++++++++++++++++- tests/twisted/Makefile.am | 1 + tests/twisted/vcard/test-vcard-cache.py | 4 +++ tests/twisted/vcard/update-rejected.py | 42 +++++++++++++++++++++++++++++++ 4 files changed, 79 insertions(+), 2 deletions(-)
+1
commit 147fa5834680583da510f6d77a5e241b840acc4a Merge: 481acb3 5d0a31b Author: Will Thompson <will.thompson@collabora.co.uk> Date: Tue Apr 28 14:02:06 2009 +0100 Merge branch 'no-avatar-for-you' Fixes fd.o#20422. Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.