Bug 20561 - test for pkg-config before using it in configure.ac
Summary: test for pkg-config before using it in configure.ac
Status: RESOLVED FIXED
Alias: None
Product: poppler
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: Other Cygwin
: low trivial
Assignee: poppler-bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-09 06:07 UTC by Brian Ewins
Modified: 2009-03-09 14:56 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
fixes the bug as described (1.14 KB, patch)
2009-03-09 06:07 UTC, Brian Ewins
Details | Splinter Review

Description Brian Ewins 2009-03-09 06:07:12 UTC
Created attachment 23689 [details] [review]
fixes the bug as described

Steps to reproduce:
run poppler's autogen.sh on a system with no pkg-config (eg cygwin)

You'll see this error:
./configure: line 22737: syntax error near unexpected token `FREETYPE,'
./configure: line 22737: `PKG_CHECK_MODULES(FREETYPE, freetype2,'

While a system missing pkg-config is probably going to have lots of problems, its helpful to test for it and print an appropriate error if its missing. The attached patch does this.
Comment 1 Albert Astals Cid 2009-03-09 14:56:33 UTC
Commited, thanks for the patch.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.