Bug 20644 - jingle/incoming-basics.py occasionally fails
Summary: jingle/incoming-basics.py occasionally fails
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: gabble (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/wj...
Whiteboard:
Keywords: patch
Depends on:
Blocks: 21966
  Show dependency tree / graph
 
Reported: 2009-03-13 04:48 UTC by Guillaume Desmottes
Modified: 2009-06-10 03:45 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Guillaume Desmottes 2009-03-13 04:48:17 UTC 
Traceback (most recent call last):
  File "/home/cassidy/dev/telepathy-gabble/tests/twisted/gabbletest.py", line 388, in exec_test_deferred
    f(queue, bus, conn, stream)
  File "./jingle/test-dialects-incoming.py", line 127, in testg4
    return worker(GtalkProtocol04(), q, bus, conn, stream)
  File "./jingle/test-dialects-incoming.py", line 82, in worker
    e = q.expect('stream-iq')
  File "/home/cassidy/dev/telepathy-gabble/tests/twisted/servicetest.py", line 242, in expect
    event = self.wait()
  File "/home/cassidy/dev/telepathy-gabble/tests/twisted/servicetest.py", line 313, in wait
    raise TimeoutError
TimeoutError
Comment 1 Will Thompson 2009-04-04 02:58:31 UTC 
This test features expect_racy :''''(
Comment 2 Will Thompson 2009-06-02 07:43:26 UTC 
Some time ago I tidied up this test and it became jingle/incoming-basics.py. I fixed a number of races in the process, and fixed another one today in the course of fixing #21996; single-patch branch at <http://git.collabora.co.uk/?p=user/wjt/telepathy-gabble-wjt.git;a=commitdiff;h=958c3c0793a4df694deeb9a4731a78e963b6314e>.

I can't see any races in it any more.
Comment 3 Guillaume Desmottes 2009-06-10 03:22:35 UTC 
Patch looks good. Maybe open a bug about the FIXME?
Comment 4 Will Thompson 2009-06-10 03:45:26 UTC 
Opened a bug for the FIXME at #22200, and merged the branch; it'll be in 0.7.29. Thanks!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.