Bug 20648 - man page update
Summary: man page update
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/Radeon (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: xf86-video-ati maintainers
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-13 09:50 UTC by Fabio Pedretti
Modified: 2009-03-18 09:16 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
radeon.man.patch (2.13 KB, patch)
2009-03-17 07:32 UTC, Fabio Pedretti
no flags Details | Splinter Review
Filter is only applied if *both* X and Y are scaled to more than double. (630 bytes, patch)
2009-03-18 03:31 UTC, Fabio Pedretti
no flags Details | Splinter Review

Description Fabio Pedretti 2009-03-13 09:50:40 UTC
The attached patch has the following updates:
* EXA and Xv are now supported on R6xx-R7xx;
* added TEXTURED VIDEO ATTRIBUTES section;
* added that EXAVSync may cause instabilities;
* added wiki page, mailing list and IRC in SEE ALSO section.
Comment 1 Fabio Pedretti 2009-03-17 07:32:15 UTC
Created attachment 23966 [details] [review]
radeon.man.patch

Oops I forgot to attach the patch (or the bugzilla eaten it).

Updated version attached.
Comment 2 Alex Deucher 2009-03-17 08:30:13 UTC
pushed:
04e36b794c216e4fa77c780fd989df1ef1c7f0d9
thanks!
Comment 3 Roland Scheidegger 2009-03-17 11:42:51 UTC
(In reply to comment #1)
> Created an attachment (id=23966) [details]
> radeon.man.patch
> 
> Oops I forgot to attach the patch (or the bugzilla eaten it).
> 
> Updated version attached.
> 

> +the filter and 'auto' means apply the filter only if one of the X or Y
> +sizes are scaled to more than double, this to avoid blurred output.
small nitpick according to the code that's not quite correct. Filter is only applied if both X and Y are scaled to more than double. (As a side note, I'm not sure exactly why it has to result in blurring - is this a bug, using wrong coefficients or something like that, or unavoidable?)
Comment 4 Fabio Pedretti 2009-03-18 03:31:13 UTC
Created attachment 23994 [details] [review]
Filter is only applied if *both* X and Y are scaled to more than double.

> > +the filter and 'auto' means apply the filter only if one of the X or Y
> > +sizes are scaled to more than double, this to avoid blurred output.
> small nitpick according to the code that's not quite correct. Filter is only
> applied if both X and Y are scaled to more than double.

Yes, you are right indeed. A small patch is attached.

> (As a side note, I'm
> not sure exactly why it has to result in blurring - is this a bug, using wrong
> coefficients or something like that, or unavoidable?)

I added this since I noticed this comment in radeon_textured_video.c:

 * Applying the bicubic filter with a scale of less than 200%
 * results in a blurred picture, so disable the filter.

Anyway I am against applying such filter by default since they loose details of the video (I usually prefer to see the original encoded video without filters) and can also overlaps with filters used by video players. However I am not sure why it's enabled when scaled larger than 2x, but not otherwise.
Comment 5 Alex Deucher 2009-03-18 09:16:03 UTC
(In reply to comment #4)

> Yes, you are right indeed. A small patch is attached.

Applied: e3e1f0c7b892b094b292081021a0e97932b8e079

> Anyway I am against applying such filter by default since they loose details of
> the video (I usually prefer to see the original encoded video without filters)
> and can also overlaps with filters used by video players. However I am not sure
> why it's enabled when scaled larger than 2x, but not otherwise.
> 

I don't recall the reasoning, ask ossman or onestone on IRC.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.