Bug 20885 - [awaiting review] Implement RemoveMembersWithReason for media channels, and use useful Group_Change_Reasons
Summary: [awaiting review] Implement RemoveMembersWithReason for media channels, and u...
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: gabble (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/wj...
Whiteboard:
Keywords:
Depends on:
Blocks: 20642 20902
  Show dependency tree / graph
 
Reported: 2009-03-26 10:49 UTC by Will Thompson
Modified: 2009-04-08 10:53 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Will Thompson 2009-03-26 10:49:09 UTC 
Gabble currently doesn't set GroupChangeReason correctly when the members of media channels change, nor does it implement RemoveMembersWithReason to allow the reason a call is ending to be transmitted to the peer. This branch fixes both of those deficits. It also ports some tests to use jingletest2, improving jt2 in the process.

 src/jingle-factory.c                               |   10 +-
 src/jingle-session.c                               |  166 ++++++++++++++++----
 src/jingle-session.h                               |    5 +-
 src/media-channel.c                                |   93 +++++++-----
 tests/twisted/Makefile.am                          |    1 +
 tests/twisted/constants.py                         |   27 +++
 tests/twisted/gabbletest.py                        |    2 +
 tests/twisted/jingle/accept-extra-stream.py        |    4 +-
 tests/twisted/jingle/google-relay.py               |   15 ++-
 tests/twisted/jingle/jingletest2.py                |   63 +++++++-
 tests/twisted/jingle/outgoing-not-answered.py      |   73 +++++++++
 tests/twisted/jingle/stream-handler-error.py       |    5 +-
 tests/twisted/jingle/stun-server.py                |    4 +-
 tests/twisted/jingle/test-content-complex.py       |   18 +--
 tests/twisted/jingle/test-description-info.py      |   15 ++-
 tests/twisted/jingle/test-dialects-incoming.py     |   25 ++--
 tests/twisted/jingle/test-incoming-call-reject.py  |  112 ++++++++------
 tests/twisted/jingle/test-incoming-call.py         |   58 +++++--
 .../twisted/jingle/test-outgoing-call-rejected.py  |   81 ++++------
 tests/twisted/jingle/test-outgoing-call.py         |    8 +-
 tests/twisted/main-debug.c                         |    3 +
 21 files changed, 555 insertions(+), 233 deletions(-)
Comment 1 Will Thompson 2009-03-27 05:06:27 UTC 
Updated the branch per Guillaume's review on #telepathy.

 src/jingle-factory.c                               |   10 +-
 src/jingle-session.c                               |  176 ++++++++++++++++----
 src/jingle-session.h                               |    5 +-
 src/media-channel.c                                |   93 ++++++-----
 tests/twisted/Makefile.am                          |    1 +
 tests/twisted/constants.py                         |   27 +++
 tests/twisted/gabbletest.py                        |    2 +
 tests/twisted/jingle/accept-extra-stream.py        |    4 +-
 tests/twisted/jingle/google-relay.py               |   17 ++-
 tests/twisted/jingle/hold-audio.py                 |    3 +-
 tests/twisted/jingle/hold-av.py                    |    6 +-
 tests/twisted/jingle/jingletest2.py                |   63 +++++++-
 tests/twisted/jingle/outgoing-not-answered.py      |   73 ++++++++
 tests/twisted/jingle/payload-types.py              |    6 +-
 tests/twisted/jingle/stream-handler-error.py       |    5 +-
 tests/twisted/jingle/stun-server.py                |    4 +-
 tests/twisted/jingle/test-content-complex.py       |   18 +--
 tests/twisted/jingle/test-description-info.py      |   19 ++-
 tests/twisted/jingle/test-dialects-incoming.py     |   27 ++--
 tests/twisted/jingle/test-dialects-outgoing.py     |    4 +-
 tests/twisted/jingle/test-incoming-call-reject.py  |  112 ++++++++-----
 tests/twisted/jingle/test-incoming-call.py         |   58 +++++--
 .../jingle/test-outgoing-call-deprecated.py        |    2 +-
 .../jingle/test-outgoing-call-deprecated2.py       |    2 +-
 .../twisted/jingle/test-outgoing-call-rejected.py  |   81 ++++------
 .../jingle/test-outgoing-call-requestotron.py      |    2 +-
 tests/twisted/jingle/test-outgoing-call.py         |   10 +-
 tests/twisted/main-debug.c                         |    3 +
 28 files changed, 585 insertions(+), 248 deletions(-)
Comment 2 Will Thompson 2009-04-08 10:53:38 UTC 
This branch was merged.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.