Created attachment 24380 [details] [review] Automake/autoconf patch libXt fails to cross-compile because makestrs needs to be called during the build process. For cross-compilation this must fail as makestrs was compiled with the target compiler. The following patch checks if we cross-compile and creates a noinstallable xmakestrs which is used during build. Created and tested against libXt-1.0.5.
This patch seems to partially duplicate and partially conflict with the cross-compiling support already committed to git master for 1.0.6 before this patch was submitted: http://cgit.freedesktop.org/xorg/lib/libXt/commit/?id=36e9f0d351afbf7fd2595990b2d39e7c551f6420 (Though as bug 23001 points out, what's there now could be better.)
Created attachment 30979 [details] [review] 0001-fix-cross-compile-again.patch Hi Alan, libXt cross-compile issues regularly pop up in Gentoo land, so I had a look at this patch here and there is value in it. The idea of this patch was to build 2 different makestrs, one with the host CC and one with the target CC. This patch effectively prevents "make install" from installing a makestrs built for the host arch. The current libXt code would be fine on as-is if makestrs never left $builddir. To follow, an updated patch based on the previous one. I've asked other Gentoo devs involved with cross-compiling environments to confirm whether this patch really works for them. Thanks
Reopening. Cheers
(In reply to comment #2) > The current libXt code would be fine on as-is if makestrs never left $builddir. I have no idea why it does. As far as I know makestrs is only used during libXt compilation, and installing it to the resulting system is a waste of time & disk space.
(In reply to comment #4) > I have no idea why it does. As far as I know makestrs is only used > during libXt compilation, and installing it to the resulting system > is a waste of time & disk space. That's what I thought too :) I'll quietly drop it from Gentoo and see if anything breaks. Thanks
Created attachment 31061 [details] [review] 0001-Don-t-install-makestrs-on-the-system.patch New patch that just marks makestrs and its man page _noinst. Cheers
Works for me - pushed to git master: commit 345633dc9c79b32a1b391dfb4dfedf87ae9e291b Author: Rémi Cardona <remi@gentoo.org> Date: Mon Nov 9 12:26:17 2009 +0100 Don't install makestrs on the system It has no known outside-libXt users. Let's not install it and its man page. Signed-off-by: Rémi Cardona <remi@gentoo.org> Signed-off-by: Alan Coopersmith <alan.coopersmith@sun.com>
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.