Bug 21166 - spec 0.17.23 will make Requests interface mandatory
Summary: spec 0.17.23 will make Requests interface mandatory
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: idle (show other bugs)
Version: unspecified
Hardware: Other All
: medium major
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/wj...
Whiteboard:
Keywords: patch
Depends on:
Blocks: 17843 20731
  Show dependency treegraph
 
Reported: 2009-04-14 04:44 UTC by Simon McVittie
Modified: 2009-09-10 16:09 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Simon McVittie 2009-04-14 04:44:55 UTC
Idle doesn't seem to implement the Requests D-Bus API. Future work, including telepathy-qt4 and probably Mission Control 5, will require that API, and it will be made mandatory in the next spec release.
Comment 1 Will Thompson 2009-08-29 06:48:37 UTC
Jonathon Jongsma and I have implemented Requests in Idle; see URL.
Comment 2 Simon McVittie 2009-09-10 08:02:01 UTC
Things not blocking merge:

The first patch would have been much, much easier to review if it was four patches:

* make IdleIMFactory into a TpChannelManager
* make IdleIMFactory stop being a TpChannelFactoryIface
* rename IdleIMFactory to reflect its new role
* rename idle-im-factory.c to idle-im-manager.c

(In Gabble, equivalents of the first two were done separately, and equivalents of the latter two haven't been done at all. Perhaps we should in 0.9.)

One day, we should re-indent Idle so it doesn't make me want to claw my eyes out.

_iface_connecting and _iface_disconnected shouldn't be commented out, they should be deleted entirely.

connection_status_changed_cb should probably switch(status).

The class should be ported to use the "pimpl" idiom (set up self->priv in init then use self->priv->bongs), like (say) TpChannel does.
Comment 3 Simon McVittie 2009-09-10 09:03:11 UTC
Ship it.
Comment 4 Will Thompson 2009-09-10 16:09:54 UTC
Merged the channel-manager branch; thanks for the review! <http://git.collabora.co.uk/?p=telepathy-idle.git;a=commit;h=6a224e80ae>

I'll fix up the trivia now; the reindenting and self->priv->...-ification can come later.x


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.