Bug 21180 - Decide where a{sv}s are needed for future expansion of clients
Summary: Decide where a{sv}s are needed for future expansion of clients
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-spec (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/sm...
Whiteboard:
Keywords: patch
Depends on:
Blocks: 21148 21256
  Show dependency treegraph
 
Reported: 2009-04-14 08:25 UTC by Simon McVittie
Modified: 2009-04-28 05:47 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Simon McVittie 2009-04-14 08:25:36 UTC
Some client methods have an a{sv} for things we haven't yet thought of. Others do not.
Comment 1 Simon McVittie 2009-04-17 10:41:57 UTC
Possible places we might want an a{sv} for future expansion:

* Observer.ObserveChannels: we already have Observer_Info

* Approver.AddDispatchOperation: if we turn the expansion things into immutable properties of the channel dispatch operation, then we're fine; the only problem is if their values can change, in which case either we use an InitialFoo hack (and don't allow the value to change until ADO has returned so the client has time to connect to signals), or the client calls back to the dispatch operation to get the initial value just after connecting to signals. Neither is a huge burden, so I don't think an a{sv} is necessarily needed.

* Handler.HandleChannels: we don't have a Handler_Info but IMO we should add one

* Handler.Interface.RequestNotification.AddRequest: we pass in exactly the request and its immutable properties, which we can always add to later; same considerations as A.ADO above.

Relatedly, ChannelRequest doesn't have an Interfaces property; for future expansion, perhaps it should. If so, MC should pass it in all the usual dicts of immutable properties.
Comment 3 Simon McVittie 2009-04-20 10:38:26 UTC
Approved by Rob and Sjoerd with their spec cabal hats on
Comment 4 Simon McVittie 2009-04-28 05:47:26 UTC
Was fixed in 0.17.23


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.