Bug 21467 - StreamTube: make StreamTubeNewConnection useful, and also rename it
Summary: StreamTube: make StreamTubeNewConnection useful, and also rename it
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-spec (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 20835
  Show dependency treegraph
 
Reported: 2009-04-28 09:47 UTC by Simon McVittie
Modified: 2009-06-16 11:04 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Simon McVittie 2009-04-28 09:47:37 UTC
+++ This bug was initially created as a clone of Bug #20835 +++

OfferStreamTube should not take an access_control_param since none of them make any sense at all in this context.

StreamTubeNewConnection should take a variant, containing the access-control-mechanism-specific access_control_param, like:

* for Port: the port the CM will connect from

* for Credentials: an arbitrary byte identifying which of several possibly concurrent connections this is (changing the definition of Credentials so it's not necessarily '\0')

* for Localhost, Netmask: there is no suitable thing, so the service cannot distinguish between different remote users (but they can't reliably distinguish between different users of the same machine either)

... except that someone needs to work out whether there is a point at which the byte can be re-used.

Also, the name is rubbish. NewStreamTubeConnection? NewConnection? New?

(Indeed, stream and D-Bus tubes are distinct types now that we're in the glorious future, so Offer, Accept would be better method names.)
Comment 1 Guillaume Desmottes 2009-04-28 10:45:13 UTC
Methods and signal has been renamed.
Comment 2 Will Thompson 2009-06-16 11:04:11 UTC
Fixed in 0.17.25.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.