Bug 21535 - X crashes with SIGSEGV in xf86_reload_cursors() with SWcursor
Summary: X crashes with SIGSEGV in xf86_reload_cursors() with SWcursor
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: 7.4 (2008.09)
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL: https://bugs.launchpad.net/bugs/371405
Whiteboard:
Keywords:
: 21275 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-05-03 18:26 UTC by Daniel Hermansson
Modified: 2010-12-19 02:53 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:

Attachments
full backtrace (18.39 KB, text/plain)
2009-05-03 18:26 UTC, Daniel Hermansson 		no flags Details
Xorg.0.log (80.83 KB, text/plain)
2009-05-03 18:27 UTC, Daniel Hermansson 		no flags Details
Fix crash in xf86_reload_cursors (640 bytes, patch)
2009-11-29 12:24 UTC, Jim Paris 		no flags Details | Splinter Review
Proposed patch (1.10 KB, patch)
2010-04-13 12:51 UTC, Jürg Billeter 		no flags Details | Splinter Review
View All

Description Daniel Hermansson 2009-05-03 18:26:22 UTC 
Created attachment 25405 [details]
full backtrace

When I enable SWcursor in xorg.conf and reboot, I get to the login screen and enter my user name and password as usual. After pressing enter, I once saw my background image, other times it's just black. Then X crashes before I see anything else. I get back to the login screen and can do the whole fun thing again countless times.

This is on the latest Ubuntu (9.04). Launchpad bug 371405.
Build Date: 09 April 2009  02:11:54AM
Comment 1 Daniel Hermansson 2009-05-03 18:27:35 UTC 
Created attachment 25406 [details]
Xorg.0.log
Comment 2 Alex Deucher 2009-05-04 07:26:20 UTC 
This is an xserver bug.  I believe it was fixed in:
7d85169c7ab1d05c21fdbb2877ffd79f344dbb6b
Comment 3 Tormod Volden 2009-05-04 13:45:00 UTC 
Commit 7d85169c7ab1d05c21fdbb2877ffd79f344dbb6b (from master) does not apply against server-1.6-branch which these guys are using, and I don't think the same typo can be found in the old code anyway. Any chance for a 1.6 fix?

BTW (for understanding the bug triaging practices) why is this bug Notourbug? If it is fixed in xserver it would be Fixed, no?
Comment 4 Alex Deucher 2009-05-04 14:01:13 UTC 
(In reply to comment #3)
> Commit 7d85169c7ab1d05c21fdbb2877ffd79f344dbb6b (from master) does not apply
> against server-1.6-branch which these guys are using, and I don't think the
> same typo can be found in the old code anyway. Any chance for a 1.6 fix?
> 

It looks like a different issue then.

> BTW (for understanding the bug triaging practices) why is this bug Notourbug?
> If it is fixed in xserver it would be Fixed, no?
> 

It's not an xf86-video-ati bug, it's presumably an xserver bug, re-opening as such.
Comment 5 Alex Deucher 2009-05-04 14:35:11 UTC 
looks like cursor_screen_priv is NULL.  maybe some issue with dixLookupPrivate()?  I don't know that code well enough.
Comment 6 Jim Paris 2009-11-29 12:24:34 UTC 
Created attachment 31555 [details] [review]
Fix crash in xf86_reload_cursors

I ran into the same problem on my system and this patch seems to fix it.
Comment 7 Julien Cristau 2010-03-01 06:52:59 UTC 
*** Bug 21275 has been marked as a duplicate of this bug. ***
Comment 8 Jürg Billeter 2010-04-13 12:51:51 UTC 
Created attachment 34977 [details] [review]
Proposed patch

Jim's patch didn't build for me, however, I've attached a very similar patch, which I've been using with X server 1.7 and 1.8 with enabled software cursors for a month now without any issues. Could someone please push this to master?
Comment 9 Jürg Billeter 2010-12-19 02:53:05 UTC 
This was fixed in master a while ago:

http://cgit.freedesktop.org/xorg/xserver/commit/?id=fa6c7012572093a82c9389682977efff85590719

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.