Bug 21751 - poppler should use pkg-config for lcms
Summary: poppler should use pkg-config for lcms
Status: RESOLVED FIXED
Alias: None
Product: poppler
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: SPARC Solaris
: medium normal
Assignee: poppler-bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-15 07:53 UTC by James Andrewartha
Modified: 2009-05-19 00:08 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
patch to use pkg-config for lcms (2.07 KB, patch)
2009-05-16 22:30 UTC, James Andrewartha
Details | Splinter Review

Description James Andrewartha 2009-05-15 07:53:30 UTC
Solaris ships the headers for lcms in /usr/include/lcms instead of /usr/include which results in configure not finding them. lcms has shipped a pkg-config file since 2006 or earlier, so using this would fix the problem, as Solaris ships an accurate lcms.pc file.
Comment 1 Albert Astals Cid 2009-05-15 15:44:24 UTC
Any chance you could contribute a patch?
Comment 2 James Andrewartha 2009-05-16 22:30:38 UTC
Created attachment 25925 [details] [review]
patch to use pkg-config for lcms

I've tested this with both cms enabled and disabled and it seems to work OK.
Comment 3 Albert Astals Cid 2009-05-17 03:07:44 UTC
I've commited a patch based on yours, please check it works for you
Comment 4 James Andrewartha 2009-05-17 04:06:43 UTC
It doesn't work, lcms.h isn't found because your patch doesn't put LCMS_CFLAGS created by PKG_CHECK_MODULES(LCMS, lcms) into CFLAGS and CXXFLAGS.
Comment 5 Albert Astals Cid 2009-05-17 11:01:25 UTC
Right, should be fixed now.
Comment 6 James Andrewartha 2009-05-17 16:40:56 UTC
Now it dies in utils/:

g++ -DHAVE_CONFIG_H -I. -I.. -I../poppler -I.. -I../utils -I../poppler  -I/space/buildbot/prefix//include   -I/space/buildbot/prefix/include/libxml2      -Wall -Wno-write-strings -g -O2 -MT pdfinfo.o -MD -MP -MF .deps/pdfinfo.Tpo -c -o pdfinfo.o pdfinfo.cc
In file included from ImageOutputDev.cc:40:
../poppler/GfxState.h:37:18: lcms.h: No such file or directory
Comment 7 Albert Astals Cid 2009-05-18 11:46:03 UTC
Third time is the good one?
Comment 8 James Andrewartha 2009-05-19 00:08:43 UTC
Yes, it worked this time. Thanks.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.