The Presence mixin's get_contact_statuses callback can raise a GError, but there's no real reason for it to do so, particularly now we have "unknown". We should deprecate raising an error; first, we need to make all code calling it first validate the handles.
Created attachment 64110 [details] [review] TpPresenceMixinGetContactStatusesFunc: remove the GError argument It is useless since handles are already guaranteed to be valid.
Comment on attachment 64110 [details] [review] TpPresenceMixinGetContactStatusesFunc: remove the GError argument Review of attachment 64110 [details] [review]: ----------------------------------------------------------------- ::: telepathy-glib/presence-mixin.c @@ +976,2 @@ > > + g_hash_table_iter_init (&iter, contact_statuses); tp-glib should still check whether contact_statuses is NULL, rather than just crashing if the CM returns NULL. (Maybe it should fill in "unknown" for all handles if the CM returns NULL? Or just leave it out of the attribute dictionary.)
Branch updated
Looks fine for next.
Thanks, merged.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.