Bug 21878 - Adding a new stream while a call's on hold makes it fall back to Pending Hold
Summary: Adding a new stream while a call's on hold makes it fall back to Pending Hold
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: gabble (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/wj...
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2009-05-22 08:17 UTC by Will Thompson
Modified: 2009-05-26 04:33 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Will Thompson 2009-05-22 08:17:47 UTC 
Suppose I call Bob, and then place the call on hold.

If either I or Bob adds a new stream, then the channel's HoldState will return to PendingHold. But, SetStreamHeld is not emitted on the new stream, so the channel will never return to state Hold.

Adding streams without taking the call off hold is a bit suspicious, but I think this should be symmetrical: regardless of who adds the stream, it shouldn't make the holder think they're not on hold, since the peer still thinks they're on hold.
Comment 1 Will Thompson 2009-05-22 08:40:51 UTC 
The attached branch fixes this bug, and adds a regression test.
Comment 2 Guillaume Desmottes 2009-05-26 04:21:34 UTC 
branc looks good
Comment 3 Will Thompson 2009-05-26 04:33:43 UTC 
Merged, will be in 0.7.28.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.