Bug 22023 - vcard/test-vcard-race.py is racy
Summary: vcard/test-vcard-race.py is racy
Status: CLOSED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: gabble (show other bugs)
Version: unspecified
Hardware: Other All
: medium critical
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/da...
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2009-06-01 10:29 UTC by Will Thompson
Modified: 2009-08-09 05:01 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
gabble debug output from test-vcard-race failing (13.51 KB, text/plain)
2009-06-18 08:53 UTC, Will Thompson 		Details
my attempt at making a race-free test failing to crash gabble (16.60 KB, text/plain)
2009-06-18 08:53 UTC, Will Thompson 		Details
my attempt at making a race-free test (1.69 KB, text/x-python)
2009-06-18 08:54 UTC, Will Thompson 		Details
View All

Description Will Thompson 2009-06-01 10:29:35 UTC 
Traceback (most recent call last):
  File "/home/wjt/src/telepathy/gabble/tests/twisted/gabbletest.py", line 381, in exec_test_deferred
    f(queue, bus, conn, stream)
  File "./vcard/test-vcard-race.py", line 55, in test
    expect_and_handle_set_vcard(q, stream, has_nickname_and_photo)
  File "/home/wjt/src/telepathy/gabble/tests/twisted/gabbletest.py", line 430, in expect_and_handle_set_vcard
    query_name='vCard', iq_type='set')
  File "/home/wjt/src/telepathy/gabble/tests/twisted/servicetest.py", line 114, in expect
    event = self.wait()
  File "/home/wjt/src/telepathy/gabble/tests/twisted/servicetest.py", line 187, in wait
    raise TimeoutError
TimeoutError
FAIL: vcard/test-vcard-race.py
Comment 1 Will Thompson 2009-06-18 02:55:36 UTC 
This is actually a crasher:

ERROR:vcard-manager.c:1010:manager_patch_vcard: assertion failed: (priv->edit_pipeline_item == NULL)
Comment 2 Will Thompson 2009-06-18 08:53:08 UTC 
Created attachment 26924 [details]
gabble debug output from test-vcard-race failing
Comment 3 Will Thompson 2009-06-18 08:53:30 UTC 
Created attachment 26925 [details]
my attempt at making a race-free test failing to crash gabble
Comment 4 Will Thompson 2009-06-18 08:54:26 UTC 
Created attachment 26926 [details]
my attempt at making a race-free test
Comment 5 Will Thompson 2009-08-08 04:14:19 UTC 
Daf's attached branch 'race-you-to-the-vcard' should fix this.
Comment 6 Will Thompson 2009-08-09 02:27:02 UTC 
I endorse this service and/or product, and have merged it. It will be in 0.7.32.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.