Bug 22091 - poppler-glib should provide POPPLER_GLIB_CHECK_VERSION etc.
Summary: poppler-glib should provide POPPLER_GLIB_CHECK_VERSION etc.
Status: RESOLVED FIXED
Alias: None
Product: poppler
Classification: Unclassified
Component: glib frontend (show other bugs)
Version: unspecified
Hardware: Other All
: medium enhancement
Assignee: poppler-bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-04 11:57 UTC by Christian Persch (GNOME)
Modified: 2009-06-05 00:53 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
patch (5.15 KB, patch)
2009-06-04 13:37 UTC, Christian Persch (GNOME) 		Details | Splinter Review
the right patch (5.15 KB, patch)
2009-06-04 13:39 UTC, Christian Persch (GNOME) 		Details | Splinter Review
Show Obsolete (1) View All

Description Christian Persch (GNOME) 2009-06-04 11:57:18 UTC 
I'd like there to be a poppler-glib analogue to GTK_CHECK_VERSION and GTK_[MAJOR|MINOR|MICRO]_VERSION defines. This is to ease conditional compiling without adding extra configure checks with AC_DEFINEs into my module.

I could prepare a patch if this would be accepted.
Comment 1 Carlos Garcia Campos 2009-06-04 12:13:03 UTC 
(In reply to comment #0)
> I'd like there to be a poppler-glib analogue to GTK_CHECK_VERSION and
> GTK_[MAJOR|MINOR|MICRO]_VERSION defines. This is to ease conditional compiling
> without adding extra configure checks with AC_DEFINEs into my module.
> 
> I could prepare a patch if this would be accepted.
>

yes, please.
Comment 2 Christian Persch (GNOME) 2009-06-04 13:37:52 UTC 
Created attachment 26444 [details] [review]
patch
Comment 3 Christian Persch (GNOME) 2009-06-04 13:39:59 UTC 
Created attachment 26445 [details] [review]
the right patch
Comment 4 Carlos Garcia Campos 2009-06-05 00:53:12 UTC 
Fixed in git master. Thanks!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.