Bug 22094 - [build] autogen created files should be removed from git
Summary: [build] autogen created files should be removed from git
Status: RESOLVED FIXED
Alias: None
Product: poppler
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: poppler-bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-04 13:08 UTC by Christian Persch (GNOME)
Modified: 2009-06-06 03:14 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
possible fix (788 bytes, patch)
2009-06-04 15:47 UTC, Christian Persch (GNOME)
Details | Splinter Review

Description Christian Persch (GNOME) 2009-06-04 13:08:27 UTC
gtk-doc.make and m4/gtk-doc.m4 are installed when running autogen, and thus shouldn't be in git.
Comment 1 Albert Astals Cid 2009-06-04 13:32:20 UTC
They are not installed here, if not present, build fails
Comment 2 Christian Persch (GNOME) 2009-06-04 15:31:13 UTC
Hmm. 

The problem is that the gtk-doc version on my system is different than the one in git, so running autogen dirties the checkout.

autogen checks for --enable-gtk-doc being passed, and only conditionally calls gtkdocize in this case. 

I think the following should work even with removing these files from git:

- adding a "-" in front of the gtk-doc.make include in glib/reference/Makefile.am, and

- replacing the GTK_DOC_CHECK call in configure with

    m4_ifdef([GTK_DOC_CHECK],[GTK_DOC_CHECK([1.0])])

Comment 3 Christian Persch (GNOME) 2009-06-04 15:47:37 UTC
Created attachment 26447 [details] [review]
possible fix

Could you test whether with this patch and removed aclocal.m4, gtk-doc.make, m4/gtk-doc.m4 files, autogen'ing (without --enable-gtk-doc of course) works without having gtk-doc installed?
Comment 4 Christian Persch (GNOME) 2009-06-04 15:48:57 UTC
Actually you also might need to comment out the EXTRA_DIST += at the end of glib/reference/Makefile.am .
Comment 5 Albert Astals Cid 2009-06-06 03:14:56 UTC
Seems to build, commited

if anyone from the gnome/gtk side comes telling i broke something i'll come after you ;-)


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.