Bug 22236 - gabble_jingle_content_produce_node and transmit_candidates contain similar but subtly-different <content> stanza generators
Summary: gabble_jingle_content_produce_node and transmit_candidates contain similar bu...
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: gabble (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on: 22467
Blocks:
  Show dependency tree / graph
 
Reported: 2009-06-11 10:20 UTC by Will Thompson
Modified: 2009-06-25 09:52 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Will Thompson 2009-06-11 10:20:07 UTC 
I noticed today that transmit_candidates() and gabble_jingle_content_produce_node() look suspiciously similar. I was tempted to replace most of the former with a call to the latter, but they actually produce different XML. One includes a <transport/> node for both gtalk4 and gtalk3, while the other only adds one for gtalk4.

I'm scared to touch this without doing a bunch of interop testing so I'm going to leave it well alone.
Comment 1 Will Thompson 2009-06-24 12:57:12 UTC 
Turns out Sjoerd removed the discrepancy in the course of implementing Google Video support; I've fixed this in my google-video branch.
Comment 2 Will Thompson 2009-06-25 09:52:51 UTC 
Merged; will be in 0.7.30.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.