Bug 22322 - [fixed in git] Make keepalive-interval parameter a uint32, like Gabble.
Summary: [fixed in git] Make keepalive-interval parameter a uint32, like Gabble.
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: rakia (show other bugs)
Version: unspecified
Hardware: Other All
: medium enhancement
Assignee: Mikhail Zabaluev
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 22321
  Show dependency tree / graph
 
Reported: 2009-06-16 11:39 UTC by Will Thompson
Modified: 2009-07-30 09:05 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Will Thompson 2009-06-16 11:39:04 UTC 
+++ This bug was initially created as a clone of Bug #22321 +++

telepathy-sofiasip has had a 'keepalive-interval' parameter for a while, and telepathy-gabble will gain one in the next release.

The former requires a int32, with -1 and 0 representing two different defaults. Gabble will require an uint32, with 0 meaning no keepalive, and a default value of 30 (corresponding to the previously hard-coded interval).

Mikhail agreed that Gabble's definition is probably more sensible; telepathy-sofiasip should be brought in line, and then we can add this to the well-known parameters in the spec.
Comment 2 Mikhail Zabaluev 2009-06-18 05:31:41 UTC 
Pushed to master.
Comment 3 Simon McVittie 2009-07-20 05:53:30 UTC 
Removing patch keyword so this doesn't show up in the review queue
Comment 4 Simon McVittie 2009-07-30 09:05:16 UTC 
Fixed in 0.5.17

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.