The GPS GConf keys (and possibly others?) should be monitored, so the master could re-configure, or restart backends that require a GPS device. 1. Add a Monitor=org.geoclue.option,org.geoclue.option2 to the provider 2. Add monitoring code to the code in main.c 3. Update config on the geoclue provider, or reload plugin.
Created attachment 26980 [details] [review] geoclue-reload-options.patch
Created attachment 26993 [details] [review] geoclue-reload-options-2.patch This will make the GPSD and Gypsy backends stop using the devices if the options end up being empty. The gpsd backend already handled changes, the Gypsy backend was fixed.
Looks good to me. Jussi?
Created attachment 27118 [details] [review] geoclue-reload-options-3.patch Note that this still isn't enough to make instant-apply work, as the master drops the subscription to geoclue-gypsy or -gpsd as it's not available to start with. We'd need to keep the unavailable providers (as opposed to the "error" ones), and kick another round of selection when their status changes (which I think already happens). The providers are also missing a status change when the device changes.
Patch looks good, committed to master branch, Thanks
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.