Created attachment 27224 [details]
patch for glxgears_pixmap black window issue by using consistent XID drawable in DRI2 interface

We found glxgears_pixmap does not work on DRI2, gallium-mesa-7.4 and xserver 1.6.2. We are seeing error message from X:
----------------------------------------------------------------------------
X Error of failed request:  BadDrawable (invalid Pixmap or Window parameter)
  Major opcode of failed request:  135 (DRI2)
  Minor opcode of failed request:  6 (DRI2CopyRegion)
  Resource id in failed request:  0x2a00005
  Serial number of failed request:  38
  Current serial number in output stream:  38

Program exited with code 01.
----------------------------------------------------------------------------

We noticed that there are some inconsistency about drawable id to use in DRI2 interfaces. For example, in dri2CreateDrawable, XID xDrawable is used to send request to X to create drawable. However, in dri2DestroyDrawable, GLXDrawable drawable is used to tell X to destroy it. And, we believe that the wrong id used in dri2CopySubBuffer causes error message above. Because XID xDrawable is the one used to create a X drawable, we are pretty sure anywhere else in DRI2 interfaces should use this id.

Attachment is a patch for this, which resolve this issue.