23081 – Handle search by TargetID broken in server/conn.py

Bug 23081 - Handle search by TargetID broken in server/conn.py

Summary: Handle search by TargetID broken in server/conn.py

Status:	RESOLVED FIXED

Alias:	None

Product:	Telepathy
Classification:	Unclassified
Component:	tp-python (show other bugs)
Version:	unspecified
Hardware:	Other Linux (All)

Importance:	high critical
Assignee:	Telepathy bugs list
QA Contact:	Telepathy bugs list

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2009-08-01 12:18 UTC by Thiago Borges Abdnur
Modified:	2009-08-03 08:57 UTC (History)
CC List:	0 users

See Also:
i915 platform:
i915 features:

Attachments
Patch to fix the problem described. (2.86 KB, patch) 2009-08-01 12:18 UTC, Thiago Borges Abdnur	Details \| Splinter Review
View All

Description Thiago Borges Abdnur 2009-08-01 12:18:38 UTC

Created attachment 28252 [details] [review]
Patch to fix the problem described.

This bug was affecting the Requests interface while using telepathy-butterfly. EnsureChannel() and CreateChannel() were reasing exceptions.

It seems that there was a semantic error regarding TargetID. This patch
changes _alter_properties() to search for TargetID in each handle, that
would be the value returned by get_name(), which is different from
handle's id. The mistake was considering TargetID == handle.get_id()
in this function.
Another change was in EnsureChannel(). It was testing if the channel
existed before fixing the request.
There was a bug in _check_basic_properties(): line 436 was enforcing the
existance of a key that is allowed to be missing.

Comment 1 Jonny Lamb 2009-08-03 08:57:39 UTC

I've committed and pushed your patch as 7cd7c74e29864a82705e19e02c72d06d8f3143e3.

Thanks for the work.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.