Actually running 0.7.31, with dbus-1.2.12 $ make check [...] Temporary bus daemon is unix:abstract=/tmp/dbus-j2QKN9GHhG,guid=3d47427307333ca627c2bbaf4a79f809 Temporary bus daemon PID is 15297 /cdo/new: process 15301: arguments to dbus_message_unref() were incorrect, assertion "message != NULL" failed in file dbus-message.c line 1391. This is normally a bug in some application using the D-Bus library. D-Bus not built with -rdynamic so unable to print a backtrace ../../tools/with-session-bus.sh: line 85: 15301 Abandon "$@" Killing temporary bus daemon: 15297 FAIL: test-channel-dispatch-operation [...] Temporary bus daemon is unix:abstract=/tmp/dbus-SS1lTV30XN,guid=0a974642254fe86601b760974a79f80a Temporary bus daemon PID is 15351 /cr/new: process 15355: arguments to dbus_message_unref() were incorrect, assertion "message != NULL" failed in file dbus-message.c line 1391. This is normally a bug in some application using the D-Bus library. D-Bus not built with -rdynamic so unable to print a backtrace ../../tools/with-session-bus.sh: line 85: 15355 Abandon "$@" Killing temporary bus daemon: 15351 FAIL: test-channel-request and them a bit later, I also saw something that makes me think the testsuite is not properly isolated from the system: Temporary bus daemon is unix:abstract=/tmp/dbus-zLo3qDmV8P,guid=0d7eb6818451723001fa27df4a79f815 Temporary bus daemon PID is 15784 ** Message: Emitted got-info (source=0) (telepathy-example-no-protocols:15804): tp-glib-DEBUG: started version 0.7.33 (telepathy-glib version 0.7.31) ** Message: Emitted got-info (source=2) Killing temporary bus daemon: 15784 PASS: test-example-no-protocols
Created attachment 28385 [details] [review] 0001-Do-not-unref-dbus-message-if-it-is-NULL.patch this patch fixes the issue.
Most of these are unneeded, because the surrounding code already checks that the message is non-NULL. But one of the dbus_message_unref (reply) calls is in an if (reply == NULL) {} block, which is wrong. The patch at <http://git.collabora.co.uk/?p=user/wjt/telepathy-glib.git;a=commitdiff;h=refs/heads/dont-unref-null-message> should fix it properly; could you check that it works for you?
(In reply to comment #0) > and them a bit later, I also saw something that makes me think the testsuite is > not properly isolated from the system: > > (telepathy-example-no-protocols:15804): tp-glib-DEBUG: started version 0.7.33 > (telepathy-glib version 0.7.31) I assume you're referring to the version discrepancy. That does look odd...
(In reply to comment #2) > Most of these are unneeded, because the surrounding code already checks that > the message is non-NULL. But one of the dbus_message_unref (reply) calls is in > an if (reply == NULL) {} block, which is wrong. The patch at > <http://git.collabora.co.uk/?p=user/wjt/telepathy-glib.git;a=commitdiff;h=refs/heads/dont-unref-null-message> > should fix it properly; could you check that it works for you? > it indeed works :)
I approve wjt's patch. As for the use of the installed telepathy-glib: are you using an LD_LIBRARY_PATH that contains your system copy of telepathy-glib? LD_LIBRARY_PATH takes precedence over just about everything, so if you are, this may be unavoidable. Failing that, I'd be interested to see how your particular build environment links examples/cm/no-protocols/telepathy-example-no-protocols (the libtool --mode=link command used if you `make clean` and rebuild it). It works correctly for me in git master: smcv@reptile% strings /usr/lib/libtelepathy-glib.so.0 | grep 0.7.33 0.7.33 smcv@reptile% ./examples/cm/no-protocols/telepathy-example-no-protocols (telepathy-example-no-protocols:17431): tp-glib-DEBUG: started version 0.7.33.1 (telepathy-glib version 0.7.33.1)
Removing patch kw so this falls out of the review queue.
The assertion failure is fixed in 0.7.34.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.