Bug 23166 - Do not build tests unless required
Summary: Do not build tests unless required
Status: RESOLVED WONTFIX
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-glib (show other bugs)
Version: unspecified
Hardware: Other All
: medium enhancement
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2009-08-05 15:27 UTC by Gilles Dartiguelongue
Modified: 2009-08-17 09:20 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
0001-Compile-test-programs-only-when-needed.patch (1.34 KB, patch)
2009-08-05 15:27 UTC, Gilles Dartiguelongue
Details | Splinter Review

Description Gilles Dartiguelongue 2009-08-05 15:27:28 UTC
Created attachment 28384 [details] [review]
0001-Compile-test-programs-only-when-needed.patch

There is no need to build tests while during make if you are not going to run make check. The attached patch fixes the issue.
Comment 1 Simon McVittie 2009-08-13 10:21:56 UTC
I'm aware of the existence of check_PROGRAMS, but I don't think it's a good idea. The tests are not very time-consuming to build, and compiling them ensures that they don't bit-rot, so I'm inclined to say WONTFIX.
Comment 2 Gilles Dartiguelongue 2009-08-13 13:23:34 UTC
building checks wihtout running them is a QA issue for us so I'll keep the patch for gentoo. FTR, I do run checks each time I upgrade a package because I really want to make sure I don't introduce obvious bugs to users :)
Comment 3 Simon McVittie 2009-08-17 09:20:12 UTC
What is your rationale for building tests unconditionally being considered a QA issue?

Following discussion with other Telepathy hackers, in the absence of a compelling reason, this is WONTFIX. We consider it to be more important that the tests always compile successfully than that a tiny amount of CPU/disk is used to do so; our rationale is that it can sometimes be necessary to skip or retry "make check" (e.g. despite developers' best efforts, async tests sometimes have race conditions), but that it is never acceptable for the tests to fail to compile at all.

I realise Gentoo and other source-based distributions are in the unusual position of wanting to compile as little as possible; you can patch this out, if you must.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.