Bug 23945 - mesa git master fails to compile in xorg_exa_tgsi.c due to changes in ureg_DECL_constant
Summary: mesa git master fails to compile in xorg_exa_tgsi.c due to changes in ureg_DE...
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Other (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: mesa-dev
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-14 14:20 UTC by Alexandre Rostovtsev
Modified: 2009-09-15 07:10 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments

Description Alexandre Rostovtsev 2009-09-14 14:20:00 UTC 
I have not been able to compile mesa git master for 2 days; when I run make, I get

[...]
xorg_exa_tgsi.c: In function 'create_fs':
xorg_exa_tgsi.c:370: error: too few arguments to function 'ureg_DECL_constant'
xorg_exa_tgsi.c:371: error: too few arguments to function 'ureg_DECL_constant'
xorg_exa_tgsi.c:372: error: too few arguments to function 'ureg_DECL_constant'
xorg_exa_tgsi.c:373: error: too few arguments to function 'ureg_DECL_constant'
xorg_exa_tgsi.c:374: error: too few arguments to function 'ureg_DECL_constant'
gmake[4]: *** [xorg_exa_tgsi.o] Error 1
gmake[4]: *** Waiting for unfinished jobs....
gmake[4]: Leaving directory `/var/tmp/portage/media-libs/mesa-9999/work/mesa_build_x86/src/gallium/state_trackers/xorg'

As far as I can tell, this is due to the changes introduced by Keith Whitwell in commits ae4704eabc237e13c9b06df9c44f31c9baca6208 and 	055fe5768c6e455b3466be47e1771711c495f1c6 which added a second argument to ureg_DECL_constant but did not update the code that uses that function.
Comment 1 Brian Paul 2009-09-14 14:51:13 UTC 
I've committed a fix which allows the code to compile again but someone more familiar with the code should double-check it...
Comment 2 Michel Dänzer 2009-09-15 07:10:29 UTC 
Keith and I think Zack acked the fix.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.