Bug 23971 - xf86-video-ati 6.12.3: broken configure.ac for cross compiling
Summary: xf86-video-ati 6.12.3: broken configure.ac for cross compiling
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/Radeon (show other bugs)
Version: unspecified
Hardware: All All
: medium normal
Assignee: xf86-video-ati maintainers
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-16 05:45 UTC by Michael Olbrich
Modified: 2009-09-20 06:24 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
patch to fix cross compiling (1.31 KB, patch)
2009-09-16 05:45 UTC, Michael Olbrich 		no flags Details | Splinter Review
updated patch (1.93 KB, patch)
2009-09-16 09:28 UTC, Michael Olbrich 		no flags Details | Splinter Review
Patch which works for me (2.35 KB, patch)
2009-09-17 01:31 UTC, Michel Dänzer 		no flags Details | Splinter Review
Show Obsolete (2) View All

Description Michael Olbrich 2009-09-16 05:45:11 UTC 
Created attachment 29591 [details] [review]
patch to fix cross compiling

configure.ac uses AC_CHECK_FILE to check for headers. That's the wrong macro.
It bails when cross compiling, because it is to check for files on the target system.
AC_CHECK_HEADER is for headers. Patch to fix this attached.
Comment 1 Michel Dänzer 2009-09-16 06:48:11 UTC 
This doesn't seem to work if some headers aren't in /usr/include - probably need some CFLAGS tricks for that...
Comment 2 Michael Olbrich 2009-09-16 09:28:25 UTC 
Created attachment 29599 [details] [review]
updated patch

next try. Is this better? I tried to do 'real' header checks but I gave up after adding the 4th extra header to include.
Any reason why the dri header don't include everything they need?
Comment 3 Michel Dänzer 2009-09-17 01:31:51 UTC 
Created attachment 29615 [details] [review]
Patch which works for me

That was close but still didn't quite work here. This one does, does it also work for you?
Comment 4 Michael Olbrich 2009-09-17 02:57:55 UTC 
Yes, the new patch works for me too.
Comment 5 Michel Dänzer 2009-09-20 06:24:50 UTC 
Fix pushed to Git master and 6.12-branch, thanks.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.