Bug 24022 - Full Index includes garbage in the interface column for interfaces and depends on a broken heuristic for determining the top-level namespace
Summary: Full Index includes garbage in the interface column for interfaces and depend...
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-spec (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/wj...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-18 08:29 UTC by Will Thompson
Modified: 2009-09-23 05:58 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments

Description Will Thompson 2009-09-18 08:29:32 UTC 
The full index has three columns: member name, type, and interface. For interfaces, these wind up being (for instance):

  Account        Interface          TheAccountManager

The third column is silly. It should be blank, or maybe the namespace of the interface?
Comment 1 Will Thompson 2009-09-18 10:10:53 UTC 
The attached branch fixes putting misc. in the third column for interfaces. It also fixes a buggy heuristic for determining the top-level namespace that I hit while designing a single-interface spec extension, and removes some code duplication.
Comment 2 Will Thompson 2009-09-18 10:32:37 UTC 
If a reviewer is feeling keen, there's an extra patch in a sub-branch at <http://git.collabora.co.uk/?p=user/wjt/telepathy-spec-wjt.git;a=shortlog;h=refs/heads/genericize-doc-generator> to make it easier to re-use the spec doc tools for extensions.
Comment 3 Danielle Madeley 2009-09-18 17:22:28 UTC 
Looks good (incl extra patch).

I was going to say "I didn't like that it was now even less generic", but then I saw your extra patch.
Comment 4 Simon McVittie 2009-09-23 05:58:40 UTC 
I reviewed and merged this.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.