Bug 24323 - Standardize pending operations
Summary: Standardize pending operations
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-qt (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/an...
Whiteboard:
Keywords:
Depends on:
Blocks: 22910
  Show dependency tree / graph
 
Reported: 2009-10-05 08:57 UTC by Andre Moreira Magalhaes
Modified: 2009-10-06 08:11 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Andre Moreira Magalhaes 2009-10-05 08:57:34 UTC 
- Change PendingSuccess/Failure/VoidMethodCall constructors to receive parent as
last param. This is the Qt idiom, and used everywhere in tp-qt4, so let's just change this now.
- Rename PendingVoidMethodCall to PendingVoid. No other pending operation have MethodCall in the name, PendingStringList/PendingVariant for example.
Comment 1 Simon McVittie 2009-10-06 05:27:19 UTC 
Fair enough. Ship it, if you feel strongly about this.

My only concern is that if the parent is always the last argument, this makes it harder to have optional arguments at the end. We could use overloaded constructors instead, I suppose...
Comment 2 Andre Moreira Magalhaes 2009-10-06 08:11:47 UTC 
Fixed upstream. It will be in next release 0.2

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.