Bug 24345 - Don't wait for caps if we already know a contact is callable.
Summary: Don't wait for caps if we already know a contact is callable.
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: gabble (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Will Thompson
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/wj...
Whiteboard: review+
Keywords: patch
Depends on:
Blocks:
 
Reported: 2009-10-06 05:40 UTC by Will Thompson
Modified: 2009-11-02 03:43 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Will Thompson 2009-10-06 05:40:51 UTC
Currently, if we're waiting for caps for a contact we delay RequestStreams(), even if we already have partial caps for them and know they're capable. The attached branch fixes this (relatively minor) issue.
Comment 1 Simon McVittie 2009-10-06 06:13:19 UTC
++ from me
Comment 3 Simon McVittie 2009-10-12 04:28:50 UTC
Also ++, although as bonus work it might be good to use gabble_capability_set_has_one() to test against a canned cap.set in one go.

It looks as though you'd need to either make two calls, one with gabble_capabilities_get_any_audio() and one with gabble_capabilities_get_any_video(), or add a gabble_capabilities_get_any_jingle_content() which is the union of those two.
Comment 4 Simon McVittie 2009-10-21 08:45:32 UTC
Is this blocked in 0.9?
Comment 5 Will Thompson 2009-10-21 08:51:30 UTC
(In reply to comment #4)
> Is this blocked in 0.9?

No, I just forgot to mention that I fixed your review comment.
Comment 6 Simon McVittie 2009-10-22 08:14:54 UTC
++ again
Comment 7 Will Thompson 2009-11-02 03:41:55 UTC
Merged and released in 0.9.2:

commit 9b77f35aa8b054a70ff8e2a5e63a3a61f21a9eb2
Merge: 6d46975 bf56a76
Author: Will Thompson <will.thompson@collabora.co.uk>
Date:   Thu Oct 22 18:54:26 2009 +0100

    Merge branch 'annie-let's-not-wait-0.9'
    
    Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
    Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.