Bug 24350 - Forgets about old activations when the bus config is reload
Summary: Forgets about old activations when the bus config is reload
Status: RESOLVED FIXED
Alias: None
Product: dbus
Classification: Unclassified
Component: core (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Havoc Pennington
QA Contact: John (J5) Palmieri
URL:
Whiteboard:
Keywords:
: 25977 (view as bug list)
Depends on:
Blocks: 23921
  Show dependency treegraph
 
Reported: 2009-10-06 10:42 UTC by Sjoerd Simons
Modified: 2010-02-02 07:36 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments
possible patch (4.46 KB, patch)
2009-12-17 18:57 UTC, Matthias Clasen
Details | Splinter Review
cleaned up patch (7.23 KB, patch)
2010-01-28 12:08 UTC, Colin Walters
Details | Splinter Review

Description Sjoerd Simons 2009-10-06 10:42:38 UTC
One of the steps D-Bus does while reloading its config is to create a new activation subsystem and unref the old one. This causes it to forget about  all pending messages to services that are currently being activated and causes them to time out, even if the service was activated successfully.
Comment 1 Colin Walters 2009-11-03 11:54:19 UTC
This is a fairly bad bug.  A few rough options:

* Queue the reload until after all pending activation requests are completed
* Rework the activation system to only load *new* .service files we haven't seen before for a reload, instead of dropping everything.
Comment 2 Matthias Clasen 2009-12-17 18:57:21 UTC
Created attachment 32165 [details] [review]
possible patch

Here is a patch which seems to do the right thing in very brief testing.
Instead of recreating a new activation, it keeps the existing one and drops its service directories and activation entries, while keeping the pending activations.

This seems to work ok in my quick testing.
Comment 3 Colin Walters 2009-12-18 13:14:52 UTC
This patch breaks the test suite; haven't had a chance to analyze why yet.

Comment 4 Colin Walters 2010-01-12 11:44:08 UTC
*** Bug 25977 has been marked as a duplicate of this bug. ***
Comment 5 Colin Walters 2010-01-28 12:08:20 UTC
Created attachment 32880 [details] [review]
cleaned up patch
Comment 6 Colin Walters 2010-01-28 12:10:32 UTC
I wasn't able to reproduce the test suite failures I saw originally with this updated patch; if we hit those later someone will need to spend some time investigating.

I believe this patch is right though.
Comment 7 Colin Walters 2010-02-02 07:36:40 UTC
Pushed to dbus-1.2 as b93476ce07acc


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.