24559 – Add SECRET flag to the password param

Bug 24559 - Add SECRET flag to the password param

Summary: Add SECRET flag to the password param

Status:	RESOLVED FIXED

Alias:	None

Product:	Telepathy
Classification:	Unclassified
Component:	idle (show other bugs)
Version:	unspecified
Hardware:	Other All

Importance:	medium normal
Assignee:	Simon McVittie
QA Contact:	Telepathy bugs list

URL:	http://git.collabora.co.uk/?p=user/sm...
Whiteboard:
Keywords:	patch

Depends on:
Blocks:

Reported:	2009-10-15 12:29 UTC by Simon McVittie
Modified:	2010-02-19 04:45 UTC (History)
CC List:	0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Simon McVittie 2009-10-15 12:29:13 UTC

telepathy-glib and telepathy-qt4 currently work around old CMs by assuming that parameters matching /(^|-)password$/ are passwords, and hence should have the SECRET flag.

They shouldn't need to do this; the SECRET flag has existed since telepathy-spec 0.17.2 and telepathy-glib 0.7.5.

As a bonus, I also fixed some configure.ac trivia in the referenced branch.

Comment 1 Guillaume Desmottes 2010-02-19 04:43:02 UTC

I assume your branch is now: http://git.collabora.co.uk/?p=user/smcv/idle-smcv.git;a=shortlog;h=refs/heads/secret

Looks good to me but you can drop this patch: http://git.collabora.co.uk/?p=user/smcv/idle-smcv.git;a=commitdiff;h=bb9df367e74b4c04ce60d80fc3d66e3a45a44492

Comment 2 Guillaume Desmottes 2010-02-19 04:45:56 UTC

I cherry-picked the 2 relevant commits. Will be in 0.1.6

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.