Bug 24584 - r300 texture size handling with size > 2048
Summary: r300 texture size handling with size > 2048
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/DRI/r300 (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Default DRI bug account
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-17 00:13 UTC by Mathias Fröhlich
Modified: 2009-10-19 08:50 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Patch for handling huge textures together with that 11-th bit (2.39 KB, patch)
2009-10-17 08:08 UTC, Mathias Fröhlich
Details | Splinter Review

Description Mathias Fröhlich 2009-10-17 00:13:00 UTC
Hi,

I have a problem with mesas teximage performance test on my r520.
The in kernel texture check fails because of both bit11 flags being set on 16x16 textures. It tuns out that these bits are still set and not cleared in the pp_txpitch field of the texture.
The attached patch at least helps for this case on my machine. It clears the bit 11 from the pitch field if the texture is smaller and masks out that hight bits on the conventional width and height field.

Not sure if this is the right fix, but that helps here and hopefully gives a clue what to fix.

thanks

Mathias
Comment 1 Nicolai Hähnle 2009-10-17 04:47:00 UTC
Thanks for looking into this, but it seems you forgot to actually attach the patch?
Comment 2 Mathias Fröhlich 2009-10-17 08:08:33 UTC
Created attachment 30501 [details] [review]
Patch for handling huge textures together with that 11-th bit

Sorry for the missing patch. Here it is!

Mathias
Comment 3 Alex Deucher 2009-10-19 08:50:45 UTC
Thanks!  pushed:
16e21191e26084848c7e6e3ffd9e15ef670855c5


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.