Bug 24686 - ICC-based colorspaces caching problem
Summary: ICC-based colorspaces caching problem
Status: RESOLVED FIXED
Alias: None
Product: poppler
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: x86 (IA32) Windows (All)
: medium normal
Assignee: poppler-bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-23 01:41 UTC by Kesarev Alexander
Modified: 2009-10-23 13:02 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Kesarev Alexander 2009-10-23 01:41:04 UTC 
Hello
I use Poppler lib (compiled with USE_CMS) to render several pdf files one by one.
I've encountered the following problem.
If Poppler renders pdf with ICC-based colorspaces it caches them in the private static cache in GfxICCBasedColorSpace using pdf stream's gen and num as a key. After that (inside the same program call) if it renders next pdf which uses the same gen and num for another colorspace it takes wrong one from the cache.
I think it would be better to have something else as a key. For example it can use pdf's ID field along with gen, num pair or some hash of the ICC stream's data. Or some public function to clean the cache might be added.
Thanks
Comment 1 Kesarev Alexander 2009-10-23 02:03:06 UTC 
The Poppler revision is 0.12.0
Comment 2 Albert Astals Cid 2009-10-23 13:02:25 UTC 
Right, i've made the cache live in Gfx, that should fix the problem, thanks a lot for reporting.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.