Bug 24729 - [ne_NP] Fix ortho file
Summary: [ne_NP] Fix ortho file
Status: RESOLVED FIXED
Alias: None
Product: fontconfig
Classification: Unclassified
Component: orth (show other bugs)
Version: 2.8
Hardware: Other All
: highest normal
Assignee: Roozbeh Pournader
QA Contact: Behdad Esfahbod
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-25 23:53 UTC by Parag
Modified: 2012-03-29 19:53 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:


Attachments
Update Nepali Ortho file (927 bytes, patch)
2009-10-25 23:53 UTC, Parag
Details | Splinter Review
Updated patch for ne.orth file (1.35 KB, patch)
2012-03-29 02:34 UTC, Pravin
Details | Splinter Review

Description Parag 2009-10-25 23:53:10 UTC
Created attachment 30685 [details] [review]
Update Nepali Ortho file

As per initial discussion happened in http://bugs.freedesktop.org/show_bug.cgi?id=23603, I would like to propose change to ne.orth file.
This new orth file will remove characters U090C, U090D, U090E.


Reference:
http://www.panl10n.net/english/Outputs%20Phase%202/CCs/Nepal/MPP/Papers/2007/0702/mpp_reports_pdf/report_character_encoding_constraints_nepali.pdf

Note: Please check patch before committing. I don't understand why last few lines are commented in hi.orth and so does now in ne.orth.
Comment 1 Parag 2009-11-24 09:13:38 UTC
Behdad,
    can someone fix this issue?
Comment 2 Behdad Esfahbod 2009-11-25 15:45:34 UTC
Roozbeh, can you please check this when you have a moment.
Comment 3 Parag 2009-11-29 23:30:03 UTC
Ping Roozbeh
Comment 4 Parag 2009-12-02 03:21:53 UTC
Ping Roozbeh
Comment 5 Roozbeh Pournader 2009-12-02 14:01:41 UTC
I have this in my queue. I guess I can handle this around the new year holidays with other orth issues, it that's not too late. If this is urgent, please tell me, so I could rush it.
Comment 6 Parag 2009-12-02 16:45:38 UTC
(In reply to comment #5)
> I have this in my queue. I guess I can handle this around the new year holidays
> with other orth issues, it that's not too late. If this is urgent, please tell
> me, so I could rush it.
> 

you can take your time. I think we have already seen need to fix this ortho since last 6 months so I think we can wait another month also.
I see no communication medium to tell you that this is urgent. Neither I can find you responding here nor I can find you on any IRC channel(in my timezone) nor you have time to look my already sent personal mail requests.

So you can take your time to fix this. we have already missed this for Fedora 12 and Fedora 13 development cycle is starting soon so no need of hurry.
Comment 7 Roozbeh Pournader 2009-12-02 17:03:55 UTC
(In reply to comment #6)
> I think we can wait another month also.

Good.

I'm taking your comment above at face value. If that wasn't your intention, please mention that explicitly, together with the reason you think Nepalese is exceptionally important. (There are several other orthographies in need of improvement too. Just look at all the orthography bugs filed against fontconfig.)

For Fedora, you can always do a version-specific patch until we fix it upstream.
Comment 8 Parag 2009-12-02 21:30:00 UTC
(In reply to comment #7)
> (In reply to comment #6)
> > I think we can wait another month also.
> 
> Good.
> 
> I'm taking your comment above at face value. If that wasn't your intention,
> please mention that explicitly, 
Sorry I do not understand what you mean here. If you have got hurt by my comment then I am sorry. I sent you few queries in personal mail already for which I really need answers to understand ortho concept so that I will see if I need to fix any other Indic language ortho or not. 

>together with the reason you think Nepalese is
> exceptionally important.
Not exceptionally important but it is the first language I worked for fixing fc-mach output and desktop font for Nepali. Once this gets fixed I will check other languages and report bugzilla for them if needed.

> (There are several other orthographies in need of
> improvement too. Just look at all the orthography bugs filed against
> fontconfig.)
sorry I do not understand how this bug is related to other ortho bugs.

> 
> For Fedora, you can always do a version-specific patch until we fix it
> upstream.
> 

I can do that anytime and build new official release on koji but I like to respect owner of fontconfig package to take decision on this.

Comment 9 Parag 2009-12-14 02:49:59 UTC
behdad,
should I build new fontconfig in Fedora that will fix this issue?
Comment 10 Behdad Esfahbod 2009-12-14 09:43:06 UTC
(In reply to comment #9)
> behdad,
> should I build new fontconfig in Fedora that will fix this issue?

no.
Comment 11 Parag 2010-04-05 03:38:04 UTC
(In reply to comment #10)
> (In reply to comment #9)
> > behdad,
> > should I build new fontconfig in Fedora that will fix this issue?
> 
> no.

Behdad,
  As per comment#7 by Roozbeh, Please can you build new fontconfig that will add Indic ortho files?
Comment 12 Parag 2010-06-16 22:46:13 UTC
(In reply to comment #11)
> (In reply to comment #10)
> > (In reply to comment #9)
> > > behdad,
> > > should I build new fontconfig in Fedora that will fix this issue?
> > 
> > no.
> 
> Behdad,
>   As per comment#7 by Roozbeh, Please can you build new fontconfig that will
> add Indic ortho files?

FYI,
   Fix for this bug is also needed by https://bugzilla.redhat.com/show_bug.cgi?id=586763
Comment 13 Behdad Esfahbod 2010-09-21 10:19:07 UTC
Fixed.

commit caa4bec9459af0779d1d16ba66964593e5748e3c
Author: Behdad Esfahbod <behdad@behdad.org>
Date:   Tue Sep 21 13:18:05 2010 -0400

    Bug 24729 - [ne_NP] Fix ortho file
    
    Exclude three characters (U+090C..090E) from Nepalese.

diff --git a/fc-lang/ne.orth b/fc-lang/ne.orth
index 18cf011..8aad4e2 100644
--- a/fc-lang/ne.orth
+++ b/fc-lang/ne.orth
@@ -23,3 +23,4 @@
 #
 # Nepali (Devanagari script) (NE)
 include hi.orth
+-090C-090E     # See bug 30685
Comment 14 Pravin 2012-03-29 01:43:20 UTC
Just gone through 2.9.0 release, this bug is yet not resolved. 

As per http://www.panl10n.net/english/Outputs%20Phase%202/CCs/Nepal/MPP/Papers/2007/0702/mpp_reports_pdf/report_character_encoding_constraints_nepali.pdf created newly .ortho file is yet not committed in upstream.

Because of this, Madan fonts specifically designed for Nepali is still not getting detected for $fc-match :lang=ne

patch given by Parag is fine.
Comment 15 Pravin 2012-03-29 02:34:56 UTC
Created attachment 59206 [details] [review]
Updated patch for ne.orth file

While checking earlier patch more, comparing to reference pdf i found few characters were extra in that corrected same now.
Comment 16 Pravin 2012-03-29 02:35:38 UTC
One character is missing in Madan fonts, i will fix it in madan fonts itself.
Comment 17 Akira TAGOH 2012-03-29 19:53:27 UTC
Thanks for the patch. fixed in 9279f71a.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.