Bug 24796 - X1400 TV-out works in 6.12.4, not in git master
Summary: X1400 TV-out works in 6.12.4, not in git master
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/Radeon (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: xf86-video-ati maintainers
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-29 14:35 UTC by druidic
Modified: 2009-11-01 14:02 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Git bisect of the offending commit (428 bytes, text/plain)
2009-10-29 14:35 UTC, druidic
no flags Details
Xorg log (265.47 KB, patch)
2009-10-29 15:18 UTC, druidic
no flags Details | Splinter Review
fix tv-out (710 bytes, patch)
2009-10-29 15:29 UTC, Alex Deucher
no flags Details | Splinter Review
Registers from a functioning TV-out (6.12.4) (188.76 KB, text/plain)
2009-10-30 00:44 UTC, druidic
no flags Details
Registers from a non-functioning TV-out (latest master) (189.30 KB, text/plain)
2009-10-30 00:44 UTC, druidic
no flags Details
xorg log of failed TV out (37.78 KB, application/octet-stream)
2009-11-01 02:32 UTC, Aljaž Prusnik
no flags Details
avivo registers (81.13 KB, application/x-gzip)
2009-11-01 05:11 UTC, Aljaž Prusnik
no flags Details
Xorg log with color tiling false option (59.33 KB, application/octet-stream)
2009-11-01 09:15 UTC, Aljaž Prusnik
no flags Details

Description druidic 2009-10-29 14:35:42 UTC
Created attachment 30817 [details]
Git bisect of the offending commit

Running

xrandr --output S-video --auto

on the latest git master gives a garbled display (both on the LCD and the TV) on X1400. It still works in 6.12.4

I'm running a minimal xorg.conf of
---
Section "Device"
       Driver "radeon"
       Option "ATOMTvOut" "true"
       Option "TVStandard" "pal"
       Identifier "Device0"
EndSection
---

I'll attach a git-bisect here as well.
Comment 1 druidic 2009-10-29 15:18:24 UTC
Created attachment 30818 [details] [review]
Xorg log
Comment 2 Alex Deucher 2009-10-29 15:29:34 UTC
Created attachment 30819 [details] [review]
fix tv-out

This patch should do the trick.
Comment 3 druidic 2009-10-29 15:40:33 UTC
Unfortunately no. Still the same issue :(
Comment 4 Alex Deucher 2009-10-29 16:25:03 UTC
can you dump the regs with avivotool in the working and non working cases and attach them here?

avivotool regs all

You can get avivotool here:
http://cgit.freedesktop.org/~airlied/radeontool
Comment 5 druidic 2009-10-30 00:44:18 UTC
Created attachment 30826 [details]
Registers from a functioning TV-out (6.12.4)
Comment 6 druidic 2009-10-30 00:44:49 UTC
Created attachment 30827 [details]
Registers from a non-functioning TV-out (latest master)
Comment 7 Aljaž Prusnik 2009-11-01 02:32:03 UTC
Created attachment 30876 [details]
xorg log of failed TV out

I'll join the cause here. I have an X1300PRO and have the same symptoms although with different output (Xorg log attached).

I tried the avivo command but got:
> mapping ctrl region
> Segmentation fault
Comment 8 druidic 2009-11-01 03:00:56 UTC
Apparently you have to run avivotool as root. It segfaulted for me as well as a normal user.
Comment 9 Aljaž Prusnik 2009-11-01 05:10:47 UTC
Thanks for the tip. However I found out that in my case it's this commit that does the difference:
5f846360c46f5a989f5d0fde6d251cdbd61d4968: radeon: clamp the internal FB map to the aperture size

After this commit, the restart of gdm results in a system hang, which with the latest commit results in a working (non-hanged) machine with the Xorg log already attached.

Then I saw the commit that reverts the one above:
1b25bad2d8ebe481ffb4b0fd3a85ab636bd4fec2 Revert "radeon: clamp the internal FB map to the aperture size"

So I hard reset git to that commit and the result is the same as with the latest commit, so the bad commit should be somewhere inbetween those commits.

I'm also attaching registers.
Comment 10 Aljaž Prusnik 2009-11-01 05:11:14 UTC
Created attachment 30878 [details]
avivo registers
Comment 11 Alex Deucher 2009-11-01 08:39:26 UTC
Does:
Option "ColorTiling" "False"
in the device section of your config fix it?
Comment 12 Aljaž Prusnik 2009-11-01 09:15:19 UTC
Created attachment 30887 [details]
Xorg log with color tiling false option

It's a progress. :) The TV screen isn't blue anymore (as in blank) but it does show to halves split vertically, left is grey and right is black. I can see when mythtv loads (the halves change patterns of colour a bit) but there's nothing resembling a desktop.
The log is attached.
Comment 13 Alex Deucher 2009-11-01 11:02:20 UTC
fixed in 52973e8f2c4104de60d00c0e5c29a31f77bf3de7
Comment 14 Aljaž Prusnik 2009-11-01 11:46:13 UTC
Indeed. It works for me. Hopefully it works for Veli-Jussi as well.
Thanx.
Comment 15 druidic 2009-11-01 14:02:23 UTC
It did, thanks!


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.