Maemo 5 uses various extended interfaces beyond what's in telepathy-spec, including those in: http://git.collabora.co.uk/?p=telepathy-mission-control.git;a=tree;f=xml;hb=master One of those is Account.Interface.Compat, which includes the "SetHasBeenOnline" method. We should decide whether it makes sense to keep this, and if so, put it in the real spec.
I think that could make sense or, even better, keep track of the last time the account has been online. So, when a client detects a connection error he can test if ($last_time_online > $last_time_account_has_been_modified) and give more info to the user: "That's probably a server or network issue" or "You probably break you account". This has been suggested in an Empathy bug IIRC.
I'm inclined to think that MC should update this internally. The Maemo 5 account creation UI signing in the connection behind MC's back to see if it works, then calling this method, is really not good. In a world where we expect MC to manage all connections (which is the world we want to live in) then it will know when accounts have been online, and when that last was.
(In reply to comment #2) > I'm inclined to think that MC should update this internally. It does, and SetHasBeenOnline should just disappear.
(In reply to comment #1) > I think that could make sense or, even better, keep track of the last time the > account has been online. > > So, when a client detects a connection error he can test if ($last_time_online > > $last_time_account_has_been_modified) and give more info to the user: "That's > probably a server or network issue" or "You probably break you account". > > This has been suggested in an Empathy bug IIRC. If you want this functionality, I think it'd make more sense as a boolean: HasBeenOnlineWithTheseParameters, or some less ugly name for the same :-) (I'm not sure that this information is enough, though, since regressions in the CM can also cause a connection error, so the CM version is another relevant variable.)
I think we should just bin this.
Created attachment 61242 [details] [review] Remove non-standard Compat interface --- I think we should bin the entire interface. Here's how!
Looks good, as long as stuff still works.
Thanks, fixed in git for 5.13.0
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.