Bug 24964 - gnome-session crashes with glibc detected double free in libSM
Summary: gnome-session crashes with glibc detected double free in libSM
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Lib/other (show other bugs)
Version: git
Hardware: x86-64 (AMD64) Linux (All)
: medium major
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
: 25054 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-11-06 15:45 UTC by Calvin Walton
Modified: 2009-11-16 19:57 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:

Attachments

Description Calvin Walton 2009-11-06 15:45:54 UTC 
When running gnome with libSM built from the latest git sources (commit 41d5bb13119b36a7ce6a344372df1b788994e2c7), I'm coming across a crash in gnome-session when some applications are started. (In particular, I see it with VirtualBox and MusicBrainz picard, both QT applications.)

Running Gentoo linux, building ~weekly Xorg from the x11 overlay.

The backtrace is the following:

*** glibc detected *** gnome-session: double free or corruption (fasttop): 0x0000000001b9c830 ***
======= Backtrace: =========
/lib/libc.so.6[0x7f673b559ac6]
/lib/libc.so.6(cfree+0x6c)[0x7f673b55e46c]
/usr/lib/libSM.so.6(_SmsProcessMessage+0x7f6)[0x7f673df0de16]
/usr/lib/libICE.so.6(IceProcessMessages+0x332)[0x7f673dcff422]
gnome-session[0x410ea2]
/usr/lib/libglib-2.0.so.0(g_main_context_dispatch+0x22d)[0x7f673bfc74bd]
/usr/lib/libglib-2.0.so.0[0x7f673bfcae78]
/usr/lib/libglib-2.0.so.0(g_main_loop_run+0x1a5)[0x7f673bfcb2d5]
/usr/lib/libgtk-x11-2.0.so.0(gtk_main+0xa7)[0x7f673d828927]
gnome-session[0x41a6ea]
/lib/libc.so.6(__libc_start_main+0xfd)[0x7f673b505a3d]
gnome-session[0x40b9b9]

This appears to have been caused by:

commit 58aa8879e10b12e478ab14b90afd1001b4abd316
Author: Michael Jansen <kde@michael-jansen.biz>
Date:   Wed Oct 14 11:01:46 2009 -0700

    Fix memory leak for SM_DeleteProperties
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@sun.com>

And, indeed, the previous commit does not exhibit the problem. Perhaps this should be reverted, pending verifying the location of the memory leak?

Please ask me if you want more details, or if I should perform further testing.
Comment 1 Alan Coopersmith 2009-11-16 15:00:03 UTC 
Pushed the revert to git master:

 src/sm_process.c |    1 -
 1 file changed, 1 deletion(-)

New commits:
commit d4e3653ff1eed208ea6f35158ad03da7729622b9
Author: Alan Coopersmith <alan.coopersmith@sun.com>
Date:   Mon Nov 16 14:57:19 2009 -0800

    Revert "Fix memory leak for SM_DeleteProperties"
    
    This reverts commit 58aa8879e10b12e478ab14b90afd1001b4abd316.
    
    Fixes gnome-session crashes due to double frees, as reported in
    http://bugs.freedesktop.org/show_bug.cgi?id=24964
Comment 2 Alan Coopersmith 2009-11-16 19:57:47 UTC 
*** Bug 25054 has been marked as a duplicate of this bug. ***

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.