Bug 25033 - [1.0] Consider renaming 'account' parameter to 'username'
Summary: [1.0] Consider renaming 'account' parameter to 'username'
Status: RESOLVED MOVED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-spec (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://cgit.freedesktop.org/~jonny/te...
Whiteboard:
Keywords: patch
Depends on:
Blocks: 68661
  Show dependency treegraph
 
Reported: 2009-11-11 06:53 UTC by Will Thompson
Modified: 2019-12-03 20:20 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Will Thompson 2009-11-11 06:53:35 UTC
I just had to explain to someone that rather than parsing the last component of an Account's object path, they should:

• Get the "Parameters" property on the Account;
• Look up the "account" key in that dict.

It's confusing enough that there's a property called Parameters (I always get these two confused), but to have one of the parameters of an Account be "account" is perverse...
Comment 1 Simon McVittie 2009-11-26 04:51:45 UTC
Incompatible change => for 1.0.
Comment 2 Will Thompson 2011-09-08 04:02:53 UTC
Heh. On IRC, 'username' is your UNIX login name-type thing, and 'account' is your nickname …
Comment 3 Mikhail Zabaluev 2012-03-02 01:28:37 UTC
"username" is not generic enough, and may not even be obviously obtainable:
in XMPP you may not know your eventual bound JID until you authenticate with whatever the auth handler supplies for it (a certificate from your smart ID card, for example).

So, what was the use case?
Comment 4 Will Thompson 2012-03-02 02:11:31 UTC
(In reply to comment #3)
> So, what was the use case?

For renaming “account”? Just human confusion.
Comment 5 Nicolas Dufresne 2012-03-02 18:26:07 UTC
I totally agree that for what we use it in telepahy, username is better.
Comment 6 Jonny Lamb 2012-05-10 09:26:03 UTC
Here's a patch. Let's finally do this.

What do you think?
Comment 7 Jonny Lamb 2012-06-07 06:50:07 UTC
(In reply to comment #6)
> What do you think?

I've decided I can't be bothered writing yet more annoying migration code in mission-control right now; we've got better things to do.

I'll leave the bug open as it's still valid enough, but I'm removing the blocking bug.
Comment 8 GitLab Migration User 2019-12-03 20:20:22 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/telepathy/telepathy-spec/issues/49.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.