Bug 25158 - new media spec implementation needs to support STUN
Summary: new media spec implementation needs to support STUN
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: gabble (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/ma...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-18 03:31 UTC by Sjoerd Simons
Modified: 2009-11-20 03:20 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Sjoerd Simons 2009-11-18 03:31:28 UTC
See subject, maiku has a branch fixing this
Comment 1 Sjoerd Simons 2009-11-18 03:48:42 UTC
Some review comments for the branch:
* in PROP_STUN_SERVERS to create the ValueArray, use gabble_value_array_build, which will cut out 
   a   big chunk of code.
* For the test instead of assert X == Y, use the assertEquals method, which generated better error
   messages  on failure
* For the test, please factor out the Call specicif test into it's own test function. Also the code 
   that checks the result of the stun check, should just be a function as currently it jsut seems 
   copy/pasted.
* Also instead of doing,  assert stream_props['Transport'] == 2 # GTALK_P2P use a constant from 
  constants.py (if there isn't one for it, please add one)
Comment 2 Mike Ruprecht 2009-11-18 13:01:55 UTC
Updated the branch per your review.
Comment 3 Sjoerd Simons 2009-11-19 03:58:03 UTC
443dd549dfb24393975e7f345cb5f5540ff42313:
  assertEquals is (expected, value), not (value, expected).. which seems to catch everyone by surprise.
Comment 4 Mike Ruprecht 2009-11-19 13:19:29 UTC
Updated the branch per your review.
Comment 5 Sjoerd Simons 2009-11-20 03:20:53 UTC
Merged, thanks


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.