Bug 25374 - xserver crash deleting properties - bisect commit 0e6cee853d8e5bef3274e632ef034d37f14674a9
Summary: xserver crash deleting properties - bisect commit 0e6cee853d8e5bef3274e632ef0...
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Input/other (show other bugs)
Version: git
Hardware: x86 (IA32) Linux (All)
: medium normal
Assignee: Peter Hutterer
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
: 25339 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-12-01 04:12 UTC by Andy Furniss
Modified: 2009-12-19 15:39 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:

Attachments
0001-Xi-reset-device-properties-to-NULL-after-deleting-th.patch (1.16 KB, patch)
2009-12-02 17:51 UTC, Peter Hutterer 		no flags Details | Splinter Review
View All

Description Andy Furniss 2009-12-01 04:12:25 UTC 
Radeon RV670 AGP card using git ddx, keyboard driver

Up dating xserver xcb and pixman to current git I am getting a crash when I quit X.

If I <ctrl><alt><bs> I hang and need to SysRq, if I <ctrl><c> from VT1 I can get console back and see backtrace.

I don't use evdev and have in xorg.conf -

Section "ServerFlags"
 Option "AllowEmptyInput" "off"
EndSection

Section "InputDevice"
        Identifier  "Keyboard0"
        Driver      "kbd"
        Option      "XkbLayout"  "gb"
EndSection

Git bisect came up with -

commit 0e6cee853d8e5bef3274e632ef034d37f14674a9
Author: Peter Hutterer <peter.hutterer@who-t.net>
Date:   Wed Nov 18 14:39:25 2009 +1000

    dix: clean up accel old scheme data when switching schemes.

Here's a trace from Xorg.log

(II) UnloadModule: "kbd"

Backtrace:
0: /home/andy/Src/Xorg-git/modular/bin/Xorg (xorg_backtrace+0x3b) [0x80df67b]
1: /home/andy/Src/Xorg-git/modular/bin/Xorg (0x8048000+0x5a0d5) [0x80a20d5]
2: (vdso) (__kernel_rt_sigreturn+0x0) [0xffffe40c]
3: /lib/libc.so.6 (0xb7381000+0x65f5e) [0xb73e6f5e]
4: /lib/libc.so.6 (__libc_malloc+0x76) [0xb73e8446]
5: /home/andy/Src/Xorg-git/modular/bin/Xorg (Xalloc+0x29) [0x80a2d19]
6: /home/andy/Src/Xorg-git/modular/bin/Xorg (Xcalloc+0x25) [0x80a3065]
7: /home/andy/Src/Xorg-git/modular/bin/Xorg (0x8048000+0xd9c4e) [0x8121c4e]
8: /home/andy/Src/Xorg-git/modular/bin/Xorg (RemoveDevice+0x25e) [0x806714e]
9: /home/andy/Src/Xorg-git/modular/bin/Xorg (DeleteInputDeviceRequest+0x52) [0x80ba012]
10: /home/andy/Src/Xorg-git/modular/bin/Xorg (0x8048000+0x1e743) [0x8066743]
11: /home/andy/Src/Xorg-git/modular/bin/Xorg (0x8048000+0x1a913) [0x8062913]
12: /lib/libc.so.6 (__libc_start_main+0xd0) [0xb7397380]
13: /home/andy/Src/Xorg-git/modular/bin/Xorg (0x8048000+0x1a4c1) [0x80624c1]
Segmentation fault at address 0xbf865e3c
Comment 1 Peter Hutterer 2009-12-02 17:51:19 UTC 
Created attachment 31696 [details] [review]
0001-Xi-reset-device-properties-to-NULL-after-deleting-th.patch

Thanks for bisecting - this patch fixes the crash on my box. Please let me know if that works for you too.
Comment 2 Andy Furniss 2009-12-03 06:28:30 UTC 
(In reply to comment #1)
> Created an attachment (id=31696) [details]
> 0001-Xi-reset-device-properties-to-NULL-after-deleting-th.patch
> 
> Thanks for bisecting - this patch fixes the crash on my box. Please let me know
> if that works for you too.
> 

Yes, the patch fixes it for me too, thanks.
Comment 3 Julien Cristau 2009-12-03 06:45:49 UTC 
Don't close until the patch is at least in master, kthxbye.
Comment 4 Sebastian Glita 2009-12-10 09:01:06 UTC 
*** Bug 25339 has been marked as a duplicate of this bug. ***
Comment 5 David Heidelberg (okias) 2009-12-19 13:25:02 UTC 
So, maybe someone can commit this patch, which fixing this bug, into master? Isn't that good idea?
Comment 6 Peter Hutterer 2009-12-19 15:39:23 UTC 
commit ea14a418214ba4c58910f5650d8b25b3fc3a7099
Author: Peter Hutterer <peter.hutterer@who-t.net>
Date:   Thu Dec 3 11:21:31 2009 +1000

    Xi: reset device properties to NULL after deleting them. (#25374)

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.